chore: fix up some code review comments
Signed-off-by: blam <ben@blam.sh>
This commit is contained in:
@@ -265,7 +265,6 @@ export class LocationReaders implements LocationReader {
|
||||
)}, ${e}`;
|
||||
emit(result.inputError(item.location, message));
|
||||
logger.warn(message);
|
||||
logger.debug(e.stack);
|
||||
return undefined;
|
||||
}
|
||||
}
|
||||
|
||||
@@ -124,7 +124,6 @@ export class DefaultCatalogProcessingOrchestrator
|
||||
};
|
||||
} catch (error) {
|
||||
this.options.logger.warn(error.message);
|
||||
this.options.logger.debug(error.stack);
|
||||
return {
|
||||
ok: false,
|
||||
errors: collector.results().errors.concat(error),
|
||||
|
||||
@@ -39,7 +39,7 @@ import { CatalogApi } from '@backstage/catalog-client';
|
||||
import { ConfigReader } from '@backstage/config';
|
||||
import express from 'express';
|
||||
import request from 'supertest';
|
||||
import { TemplateEntityV1beta2 } from '../../../../packages/catalog-model/src';
|
||||
import { TemplateEntityV1beta2 } from '@backstage/catalog-model';
|
||||
import { createRouter } from './router';
|
||||
|
||||
const createCatalogClient = (templates: any[] = []) =>
|
||||
|
||||
Reference in New Issue
Block a user