Commit Graph

71351 Commits

Author SHA1 Message Date
John Collier 4445d88cff address pr review feedback
Signed-off-by: John Collier <jcollier@redhat.com>
2026-03-05 10:54:33 -05:00
John Collier f5fb2829f7 address review feedback
Signed-off-by: John Collier <jcollier@redhat.com>
2026-03-04 23:00:02 -05:00
John Collier 2375ad9a83 Generate api reports
Signed-off-by: John Collier <jcollier@redhat.com>
2026-03-04 16:42:46 -05:00
John Collier 77bee9f013 feat(scaffolder): Allow sorting by status in scaffolderService.listTasks.
Added optional `status` filter to `ScaffolderService.listTasks`, by exposing the `status` query parameter,  allowing callers to retrieve tasks of a specific status. Also updated the `list-scaffolder-tasks` action to support this parameter.

Signed-off-by: John Collier <jcollier@redhat.com>
2026-03-04 16:25:29 -05:00
Carl-Erik Bergström 545557a928 feat(backend-app-api): attribute registration errors to plugins/modules (#33029)
* feat(backend-app-api): attribute registration errors to plugins/modules

Signed-off-by: Carl-Erik Bergström <cbergstrom@spotify.com>
2026-03-03 19:12:44 +01:00
Charles de Dreuille 95fecdf617 Merge pull request #33081 from backstage/ui/searchfield-textfield-bg-focus
feat(ui): bg-context support and focus ring for SearchField and TextField
2026-03-03 15:56:01 +00:00
Fredrik Adelöw d69aa8689e Merge pull request #32994 from backstage/changeset-release/master
Version Packages (next)
2026-03-03 16:53:22 +01:00
Charles de Dreuille 62d674c3de Merge branch 'master' into ui/searchfield-textfield-bg-focus
# Conflicts:
#	packages/ui/src/components/PluginHeader/PluginHeader.module.css
#	packages/ui/src/components/PluginHeader/PluginHeader.tsx
#	packages/ui/src/components/PluginHeader/PluginHeaderToolbar.tsx
2026-03-03 14:16:54 +00:00
github-actions[bot] db0d171511 Version Packages (next) 2026-03-03 14:16:49 +00:00
Johan Persson 8211dc0f70 chore(ui): remove inline style from Button in Card story
Signed-off-by: Johan Persson <johanopersson@gmail.com>
2026-03-03 15:11:28 +01:00
Johan Persson 36987dbdfd chore(ui): add changesets and update API report
Signed-off-by: Johan Persson <johanopersson@gmail.com>
2026-03-03 15:11:28 +01:00
Johan Persson bfd121436b fix(ui): extend FieldLabelProps with native div element props
FieldLabel renders a div and spreads restProps onto it, but
FieldLabelProps didn't extend native div props. This meant
attributes like aria-*, data-*, role, etc. couldn't be
passed with type safety.

Signed-off-by: Johan Persson <johanopersson@gmail.com>
2026-03-03 15:11:28 +01:00
Johan Persson 8236a3d7c3 fix(ui): extend ContainerProps with native div element props
Container renders a div and spreads restProps onto it, but
ContainerProps didn't extend native div props. This meant
attributes like aria-*, data-*, role, etc. couldn't be
passed with type safety.

Signed-off-by: Johan Persson <johanopersson@gmail.com>
2026-03-03 15:11:28 +01:00
Johan Persson 68e0cc1468 fix(ui): extend AlertProps with native div element props
Alert renders a div and spreads restProps onto it, but
AlertProps didn't extend native div props. This meant
attributes like aria-*, data-*, role, etc. couldn't be
passed with type safety.

Signed-off-by: Johan Persson <johanopersson@gmail.com>
2026-03-03 15:11:28 +01:00
Johan Persson 6edae0e959 fix(ui): remove unused style prop from ButtonLinkOwnProps
The style prop was defined in ButtonLinkOwnProps but never
destructured or applied in the component, causing it to be
silently dropped. Removing it lets style flow through to the
underlying RAC Link via restProps instead.

Signed-off-by: Johan Persson <johanopersson@gmail.com>
2026-03-03 15:11:28 +01:00
Johan Persson 00bf7c7e42 fix(ui): remove unused style prop from ButtonOwnProps
The style prop was defined in ButtonOwnProps but never
destructured or applied in the component, causing it to be
silently dropped. Removing it lets style flow through to the
underlying RAC Button via restProps instead.

Signed-off-by: Johan Persson <johanopersson@gmail.com>
2026-03-03 15:11:28 +01:00
Johan Persson bd671414bb fix(ui): remove unused style prop from ButtonIconOwnProps
The style prop was defined in ButtonIconOwnProps but never
destructured or applied in the component, causing it to be
silently dropped. Removing it lets style flow through to the
underlying RAC Button via restProps instead.

Signed-off-by: Johan Persson <johanopersson@gmail.com>
2026-03-03 15:11:28 +01:00
Johan Persson 8d40a035dc fix(ui): extend DialogBodyProps with native div element props
DialogBodyProps previously only extended DialogBodyOwnProps,
meaning native HTML attributes like aria-*, data-*, etc.
could not be passed to the underlying div element.

Signed-off-by: Johan Persson <johanopersson@gmail.com>
2026-03-03 15:11:28 +01:00
Charles de Dreuille e8c8e0fe30 Merge pull request #33085 from backstage/cdedreuille/merge-plugin-header-toolbar
Style improvements on PluginHeader
2026-03-03 14:01:27 +00:00
Charles de Dreuille 8c35030431 Merge pull request #33096 from backstage/update-storybook-docsui-codeowners
chore: add design-system-maintainers as code owners for .storybook and docs-ui
2026-03-03 13:59:08 +00:00
Johan Persson aa59ab0ede chore: add design-system-maintainers as code owners for .storybook and docs-ui
These directories were previously only covered by the catch-all
rule, requiring review from @backstage/maintainers. Since they
fall under the Design System project area scope, assign them to
@backstage/design-system-maintainers.

Signed-off-by: Johan Persson <johanopersson@gmail.com>
2026-03-03 14:41:57 +01:00
Andre Wanlin 21d8beec83 Merge pull request #33083 from backstage/visibility
Update Azure integration config visibility
2026-03-03 06:49:36 -06:00
Ben Lambert 6c6a41c4d1 fix(scaffolder-backend-module-gitlab): update GroupMembers.add for gitbeaker v43 (#33091)
@gitbeaker/core v43 changed ResourceMembers.add signature to
accept accessLevel as the second arg and userId in an options object.

Signed-off-by: benjdlambert <ben@blam.sh>
2026-03-03 10:48:40 +00:00
Patrik Oldsberg 9562f04d7f Merge pull request #33084 from backstage/rugvip/fix-prepack-postpack-cjs-compat
cli: fix prepack and postpack commands CJS compat
2026-03-03 10:29:07 +01:00
Jellyfrog 0c1726a5d1 feat(scaffolder-backend-module-gitlab): add gitlab:group:access action (#32528)
* feat(scaffolder-backend-module-gitlab): add gitlab:group:access action

Add a new scaffolder action to add or remove users and groups as members
of GitLab groups. The action supports specifying access levels (Guest,
Reporter, Developer, Maintainer, Owner) when adding members and includes
dry-run support.

Signed-off-by: Jellyfrog <Jellyfrog@users.noreply.github.com>

* Update plugins/scaffolder-backend-module-gitlab/src/actions/gitlabGroupAccessAction.ts

Signed-off-by: Fredrik Adelöw <freben@gmail.com>

* Update plugins/scaffolder-backend-module-gitlab/src/actions/gitlabGroupAccessAction.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Jellyfrog <Jellyfrog@users.noreply.github.com>

* Update plugins/scaffolder-backend-module-gitlab/src/actions/gitlabGroupAccessAction.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Jellyfrog <Jellyfrog@users.noreply.github.com>

* Update gitlabGroupAccessAction to use parseRepoHost and conditionally resolve access level

Use parseRepoHost instead of parseRepoUrl since only the host is needed,
and skip resolveAccessLevel for remove actions where access level is unused.

Signed-off-by: Jellyfrog <Jellyfrog@users.noreply.github.com>

---------

Signed-off-by: Jellyfrog <Jellyfrog@users.noreply.github.com>
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
Co-authored-by: Fredrik Adelöw <freben@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2026-03-03 10:25:04 +01:00
Charles de Dreuille 8ab2d7c3a2 Update spotify.css
Signed-off-by: Charles de Dreuille <charles.dedreuille@gmail.com>
2026-03-03 08:41:06 +00:00
John Collier c9b11eb0cf feat(scaffolder): Create basic scaffolder task query action (#32989)
* feat(scaffolder): Create basic scaffolder task query action

Signed-off-by: John Collier <jcollier@redhat.com>

* Add changeset

Signed-off-by: John Collier <jcollier@redhat.com>

* Fix test

Signed-off-by: John Collier <jcollier@redhat.com>

* Address review feedback

Signed-off-by: John Collier <jcollier@redhat.com>

* Update plugins/scaffolder-backend/src/actions/listScaffolderTasksAction.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: John Collier <jcollier@redhat.com>

* Update plugins/scaffolder-backend/src/actions/listScaffolderTaskAction.test.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: John Collier <jcollier@redhat.com>

* Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: John Collier <jcollier@redhat.com>

* lint

Signed-off-by: John Collier <jcollier@redhat.com>

* fix conflict markers, remove unused discovery dep, add input validation bounds

Signed-off-by: benjdlambert <ben@blam.sh>

* address PR feedback: fix status enum, add int validation, improve changeset

Signed-off-by: benjdlambert <ben@blam.sh>

---------

Signed-off-by: John Collier <jcollier@redhat.com>
Signed-off-by: benjdlambert <ben@blam.sh>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: benjdlambert <ben@blam.sh>
2026-03-03 08:38:09 +00:00
Stephanie Cao 7695dd23d0 feat(scaffolder): Create scaffolder mcp action to list all installed template actions (#32765)
* add scaffolder mcp action to list all installed template actions

Signed-off-by: Stephanie <yangcao@redhat.com>

* add changeset

Signed-off-by: Stephanie <yangcao@redhat.com>

* resolve review comments

Signed-off-by: Stephanie <yangcao@redhat.com>

* cleanup code

Signed-off-by: Stephanie <yangcao@redhat.com>

* resolve pr review comments

Signed-off-by: Stephanie <yangcao@redhat.com>

* remove actionService param in options, as templateActionsRegistry has already been passed in

Signed-off-by: Stephanie <yangcao@redhat.com>

* remove unnecessary required param check

Signed-off-by: Stephanie <yangcao@redhat.com>

* type the mcp action output better

Signed-off-by: Stephanie <yangcao@redhat.com>

* use scaffolderService instead

Signed-off-by: Stephanie <yangcao@redhat.com>

* revert templateActionRegistry rename, keep actionRegistry as-is

Signed-off-by: benjdlambert <ben@blam.sh>

* clean up list-scaffolder-actions: fix tests, changeset, and description

Signed-off-by: benjdlambert <ben@blam.sh>

---------

Signed-off-by: Stephanie <yangcao@redhat.com>
Signed-off-by: benjdlambert <ben@blam.sh>
Co-authored-by: benjdlambert <ben@blam.sh>
2026-03-03 07:30:06 +00:00
Patrik Oldsberg 732f3eb50f cli: remove changeset
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Made-with: Cursor
2026-03-02 20:51:46 +01:00
Patrik Oldsberg 11764eff33 cli: remove stale lib/lazy.ts from previous stash
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Made-with: Cursor
2026-03-02 20:50:26 +01:00
Patrik Oldsberg e8a5a20f7d cli: split pack.ts into prepack.ts and postpack.ts
Each file now has a default export matching the CommandExecuteFn
pattern, removing the need for import wrapping in the loader.

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Made-with: Cursor
2026-03-02 20:49:56 +01:00
James Brooks d73ac23f1e Merge branch 'master' into visibility 2026-03-02 19:08:00 +00:00
Charles de Dreuille 4105a78f98 Style improvements on PluginHeader
Signed-off-by: Charles de Dreuille <charles.dedreuille@gmail.com>
2026-03-02 19:07:03 +00:00
Charles de Dreuille 077674b93b Update report.api.md
Signed-off-by: Charles de Dreuille <charles.dedreuille@gmail.com>
2026-03-02 17:44:25 +00:00
Charles de Dreuille eee3c14329 Fix SearchField styles
Signed-off-by: Charles de Dreuille <charles.dedreuille@gmail.com>
2026-03-02 17:31:53 +00:00
Patrik Oldsberg f867152e8b cli: fix prepack and postpack commands CJS compat
Switch the prepack and postpack commands from using a direct
dynamic import() to the execute.loader pattern, which properly
handles CJS double-wrapping of module exports.

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Made-with: Cursor
2026-03-02 17:33:35 +01:00
James Brooks 993a59840b Update Azure integration config visibility
Signed-off-by: James Brooks <jamesbrooks@spotify.com>
2026-03-02 15:02:39 +00:00
Johan Persson a0e4d38f4b fix(ui): use Text as="p" in Tabs stories for proper line breaks
Story description text was rendering inline without line breaks
between elements. Add as="p" to Text components so each renders
as a block-level paragraph.

Signed-off-by: Johan Persson <johanopersson@gmail.com>
2026-03-02 15:51:07 +01:00
Johan Persson d4fa5b4ee0 fix(ui): strip query params from tab href before active-state matching
Tab matchStrategy ('exact' and 'prefix') compared the raw tab href
against location.pathname, which never includes query params. This
meant tabs with query params in their href could never be matched
as active.

Extract an hrefPathname helper that strips query params and hash
fragments, and use it in both isTabActive and the segment count
computation.

Signed-off-by: Johan Persson <johanopersson@gmail.com>
2026-03-02 15:51:07 +01:00
Charles de Dreuille 5476d22724 Update ui-searchfield-textfield-bg-focus.md
Signed-off-by: Charles de Dreuille <charles.dedreuille@gmail.com>
2026-03-02 13:51:29 +00:00
Charles de Dreuille de701ee95f Update accept.txt
Signed-off-by: Charles de Dreuille <charles.dedreuille@gmail.com>
2026-03-02 13:49:34 +00:00
Charles de Dreuille f2588154a2 Merge pull request #33078 from backstage/cdedreuille/ui-neutral-bg-simplification
Fix neutral hover state token
2026-03-02 13:49:01 +00:00
Charles de Dreuille 934ac03ce6 Improve SearchField + TextField look
Signed-off-by: Charles de Dreuille <charles.dedreuille@gmail.com>
2026-03-02 13:44:35 +00:00
Charles de Dreuille 58224d3476 Create bumpy-colts-teach.md
Signed-off-by: Charles de Dreuille <charles.dedreuille@gmail.com>
2026-03-02 12:52:54 +00:00
Charles de Dreuille da54fd24ef Update tokens.css
Signed-off-by: Charles de Dreuille <charles.dedreuille@gmail.com>
2026-03-02 12:43:44 +00:00
Fredrik Adelöw 3438d4f800 Merge pull request #33075 from backstage/fix/generate-catalog-info-allow-excess-args
fix(repo-tools): re-add allowExcessArguments for generate-catalog-info
2026-03-02 11:50:51 +01:00
Johan Persson 426edbef9c fix(repo-tools): allow excess arguments for generate-catalog-info command
Re-add `.allowExcessArguments(true)` which was dropped during
conflict resolution in the Commander v14 upgrade (PR #32583).

lint-staged passes staged file paths as extra arguments when
invoking `generate-catalog-info` via the pre-commit hook, causing
Commander v14 to reject them with "too many arguments".

Signed-off-by: Johan Persson <johanopersson@gmail.com>
2026-03-02 11:36:02 +01:00
Stephanie Cao ccc20cf1bc feat(scaffolder): Create scaffolder mcp action to dry run scaffolder template (#32914)
* dry run action

Signed-off-by: Stephanie <yangcao@redhat.com>

* add tests

Signed-off-by: Stephanie <yangcao@redhat.com>

* add changeset

Signed-off-by: Stephanie <yangcao@redhat.com>

* adjust review comments

Signed-off-by: Stephanie <yangcao@redhat.com>

* update error handling

Signed-off-by: Stephanie <yangcao@redhat.com>

* remove unnecessary import

Signed-off-by: Stephanie <yangcao@redhat.com>

* replace ScaffolderClient with scaffolderServiceRef

Signed-off-by: benjdlambert <ben@blam.sh>

---------

Signed-off-by: Stephanie <yangcao@redhat.com>
Signed-off-by: benjdlambert <ben@blam.sh>
Co-authored-by: benjdlambert <ben@blam.sh>
2026-03-02 10:41:42 +01:00
Fredrik Adelöw 889aee97a6 Merge pull request #33066 from backstage/freben/fix-owner-relation-docs 2026-03-01 18:04:57 +01:00
Patrik Oldsberg 1f7786e629 Merge pull request #33067 from backstage/rugvip/add-elaine-mattos-org-member
Added elaine-mattos to the Org Member list
2026-03-01 14:16:32 +01:00