Commit Graph

643 Commits

Author SHA1 Message Date
Ben Lambert 16a1aed6e8 Merge pull request #12631 from kjuulh/feature/require-valid-owner-in-owner-picker
Add allowArbitraryValues to <OwnerPicker />
2022-07-14 14:20:56 +02:00
kjuulh 180c06d623 Change boolean pipe to a Optional chaining pipe
Change boolean pipe to a Optional chaining pipe

Signed-off-by: kjuulh <contact@kjuulh.io>
2022-07-14 13:19:09 +02:00
kjuulh 3bce493156 Add allowArbitraryValues to <OwnerPicker />
This change makes the OwnerPicker able to validate that the selected
option is one of the provided values. This should provide a smoother
experience for users, as they now can only enter valid values on the
client side

None of the tests are changed, as this value is passed to MUI, which
is the library containing the validation.

Signed-off-by: kjuulh <contact@kjuulh.io>
2022-07-14 13:19:09 +02:00
Thomas Cardonne 1764296a68 feat(scaffolder): allow to create Gerrit project using default owner
Signed-off-by: Thomas Cardonne <thomas.cardonne@adevinta.com>
2022-07-13 11:51:45 +02:00
Patrik Oldsberg aa2877058b Merge pull request #12471 from boschresearch/fix/default-value-allowed-fields
set default owner/repo when more than 1 allowed values defined
2022-07-07 13:22:45 +02:00
Jonathan Ash d600cb2ab6 contextMenu prop passed through to ScaffolderPage from Router
Signed-off-by: Jonathan Ash <jonathan-ash@users.noreply.github.com>
2022-07-06 16:39:24 +01:00
Julius Berger a1e12ab502 set default owner/repo when more than 1 allowed values defined
Signed-off-by: Julius Berger <julius.berger@de.bosch.com>
2022-07-06 11:55:47 +02:00
Ben Lambert 5a98712ce3 Merge pull request #11806 from dotressel/add-allowed-repos-to-repourlpicker
Scaffolder: RepoUrlPicker: Add allowedRepos Option and move RepoName Input to own Component
2022-06-29 16:00:06 +02:00
blam 2dae0427cf chore: removing the failing tests that have been replaced with the other functionality
Signed-off-by: blam <ben@blam.sh>
2022-06-29 15:37:40 +02:00
blam ed45ee23fa chore: added some simple tests
Signed-off-by: blam <ben@blam.sh>
2022-06-29 14:21:57 +02:00
Joan Aymà 2674a4148f add allowArbitraryValues to OwnedEntityPicker ui:options list
Signed-off-by: Joan Aymà <joan.ayma@clarivate.com>
2022-06-28 13:32:45 +02:00
Joan Aymà 14146703e5 Add allowArbitraryValues in OwnedEntityPicker
Signed-off-by: Joan Aymà <joan.ayma@clarivate.com>
2022-06-28 12:59:32 +02:00
Patrik Oldsberg 747c6e29b1 Merge pull request #12176 from backstage/rugvip/smaller
scaffolder: reduce max file size for dry-run content
2022-06-21 10:19:26 +02:00
Patrik Oldsberg 464bb0e6c8 scaffolder: reduce max file size for dry-run content
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-06-21 10:00:12 +02:00
Patrik Oldsberg 37539e29d8 scaffolder: show dry-run error cause
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-06-21 09:48:58 +02:00
Patrik Oldsberg 6532c8084a remove usage of @ts-ignore
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-06-17 18:03:58 +02:00
Phil Kuang a7c0b34d70 refactor(ListTasksPage): swap MaterialTable with Table
Signed-off-by: Phil Kuang <pkuang@factset.com>
2022-06-15 14:00:02 -04:00
Maximilian Ressel 8ebc1dea21 Add allowedRepos Option and move Repo Field to own Component
Signed-off-by: Maximilian Ressel <maximiliandotressel@gmail.com>
2022-06-15 16:54:31 +02:00
blam 0a8b212165 chore: wrong line
Signed-off-by: blam <ben@blam.sh>
2022-06-09 16:22:08 +02:00
blam f93af969cd chore: tidying up a little bit and added changeset
Signed-off-by: blam <ben@blam.sh>
2022-06-09 16:15:13 +02:00
blam f780859eb0 feat: added the ability to run namespaced templates
Signed-off-by: blam <ben@blam.sh>
2022-06-09 16:12:16 +02:00
Patrik Oldsberg fd505f40c0 scaffolder: fix binary file uploads during dry-run
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-06-03 13:37:25 +02:00
Ben Lambert 9943557a57 Merge pull request #11154 from angeliski/add-tasks-owner
Add tasks owner
2022-06-01 11:16:37 +02:00
Ben Lambert bd671d0696 Merge pull request #11732 from ivd-git/scaffolder-review-mask-bugfix-11687
Make code work as documented. Review mask does not need 'show: true'.…
2022-06-01 10:52:09 +02:00
blam 698c55f182 chore: code review changes
Signed-off-by: blam <ben@blam.sh>
2022-05-31 16:42:51 +02:00
Ingmar van Dijk b9ce08bbb8 Fix code style on MultistepJsonForm. Prettier check will pass now.
Signed-off-by: Ingmar van Dijk <ingmar.van.dijk@philips.com>
2022-05-31 16:17:25 +02:00
Ingmar van Dijk 115214b719 Make code work as documented. Review mask does not need 'show: true'. (#11687)
Signed-off-by: Ingmar van Dijk <ingmar.van.dijk@philips.com>
2022-05-31 16:16:19 +02:00
blam 69b737c568 Merge remote-tracking branch 'origin' into add-tasks-owner
* origin: (56 commits)
  scaffolder-backend: fix merge conflict in router
  scaffolder: disable global save button in template editor if no files are dirty
  scaffolder: update API report
  scaffolder: remove unnecessary TemplateFileSystemAccess interface
  scaffolder: wrap dry-run log body in an outer object
  scaffolder: fix life
  scaffolder: make dry-run secrets optional to match task execution
  scaffolder: rename dry-run contents -> directoryContents
  scaffolder-backend: refactor actions to use serializeDirectoryContents
  scaffolder-backend: clarifying comment about done
  scaffolder-backend: add dry-run request body validation
  scaffolder-backend: validate dry-run template input
  sfaffolder: switch /v2/dryrun to /v2/dry-run
  scaffolder,scaffolder-backend: fix API reports
  scaffolder: fix dryRun implementation in ScaffolderClient
  scaffolder: add test for TemplateEditorBrowser
  scaffolder: add test for TemplateEditorPage
  scaffolder: add test for DryRunResultsView
  scaffolder: memo methods in DryRunProvider
  scaffolder: add DryRunResultsList tests
  ...

Signed-off-by: blam <ben@blam.sh>
2022-05-31 14:58:51 +02:00
Patrik Oldsberg 139f8f08a2 scaffolder: disable global save button in template editor if no files are dirty
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-05-31 13:24:25 +02:00
Patrik Oldsberg a2490f64fe scaffolder: remove unnecessary TemplateFileSystemAccess interface
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-05-31 13:24:25 +02:00
Patrik Oldsberg 73e427c405 scaffolder: wrap dry-run log body in an outer object
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-05-31 13:24:25 +02:00
Patrik Oldsberg b817af39ad scaffolder: make dry-run secrets optional to match task execution
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-05-31 13:24:25 +02:00
Patrik Oldsberg c7a5d8d7ae scaffolder: rename dry-run contents -> directoryContents
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-05-31 13:24:24 +02:00
Patrik Oldsberg 36c39f9b42 sfaffolder: switch /v2/dryrun to /v2/dry-run
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-05-31 13:24:24 +02:00
Patrik Oldsberg b622410ef0 scaffolder,scaffolder-backend: fix API reports
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-05-31 13:24:24 +02:00
Patrik Oldsberg 636dc85781 scaffolder: fix dryRun implementation in ScaffolderClient
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-05-31 13:24:24 +02:00
Patrik Oldsberg d59ec5c6d5 scaffolder: add test for TemplateEditorBrowser
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-05-31 13:24:24 +02:00
Patrik Oldsberg 01db4019e0 scaffolder: add test for TemplateEditorPage
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-05-31 13:24:24 +02:00
Patrik Oldsberg 71228274ae scaffolder: add test for DryRunResultsView
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-05-31 13:24:24 +02:00
Patrik Oldsberg e48ca034e9 scaffolder: memo methods in DryRunProvider
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-05-31 13:24:24 +02:00
Patrik Oldsberg 4b839c4f02 scaffolder: add DryRunResultsList tests
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-05-31 13:24:24 +02:00
Patrik Oldsberg 88b81c3e6f scaffolder: add tests for DryRunResults
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-05-31 13:24:24 +02:00
Patrik Oldsberg 05b6044399 scaffolder: memo DryRunContext value
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-05-31 13:24:24 +02:00
Patrik Oldsberg ace95e391c scaffolder: flatten TemplateEditorPage structure
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-05-31 13:24:24 +02:00
Patrik Oldsberg 289d349199 scaffolder: always show file reload in TemplateEditorTextArea
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-05-31 13:24:23 +02:00
Patrik Oldsberg f7805dfea8 scaffolder: add wrapper to TemplateEditorForm to handle overflow
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-05-31 13:24:23 +02:00
Patrik Oldsberg c98cfa0e6c scaffolder: refactor TemplateFormPreviewer to use common components
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-05-31 13:24:23 +02:00
Patrik Oldsberg 3c87f60481 scaffolder: tweak names of TemplateEditor components
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-05-31 13:24:23 +02:00
Patrik Oldsberg 6758e83662 scaffolder: extract TemplateEditorBrowser
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-05-31 13:24:23 +02:00
Patrik Oldsberg 5146bc96fc scaffolder: extract TemplateEditorForm
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-05-31 13:24:23 +02:00