21074 Commits

Author SHA1 Message Date
Johan Persson 1f709a386b fix(ui): preserve Header breadcrumb typography
Increase the specificity of Header breadcrumb styles so that Link defaults do not override contextual typography when stylesheets are loaded in a different order.

Add a patch changeset for @backstage/ui.

Signed-off-by: Johan Persson <johanopersson@gmail.com>
2026-06-01 11:32:46 +02:00
Charles de Dreuille c2f9d8c25d Merge pull request #34400 from backstage/feat/bui-token-redesign
feat(ui): introduce semantic color token families and deprecate legacy tokens
2026-05-29 15:40:20 +01:00
Charles de Dreuille 78f6fd3b5b Small fixes
Signed-off-by: Charles de Dreuille <charles.dedreuille@gmail.com>
2026-05-29 16:07:56 +02:00
Charles de Dreuille a4f2c56110 Bring back correct neutral tokens
Signed-off-by: Charles de Dreuille <charles.dedreuille@gmail.com>
2026-05-29 15:59:39 +02:00
Charles de Dreuille 64c8108166 Move to minor
Signed-off-by: Charles de Dreuille <charles.dedreuille@gmail.com>
2026-05-29 13:35:11 +02:00
Fredrik Adelöw 8f7c02a525 Merge pull request #34425 from backstage/freben/fix-msgraph-group-member-filter
fix(catalog-backend-module-msgraph): filter disabled group members client-side
2026-05-29 10:41:55 +02:00
Fredrik Adelöw 4857351bf3 Merge pull request #34415 from stijnbrouwers/bugfix/gitlab-archive-fetch 2026-05-28 17:52:36 +02:00
Fredrik Adelöw bbb9ca105f Fix inconsistent accountEnabled wording across docs and changeset
Consistently use 'accountEnabled === false' everywhere to describe
which users are filtered out.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2026-05-28 17:02:02 +02:00
Fredrik Adelöw ce2e763606 Address review: use === true, update docs, add tests
- Use accountEnabled === true instead of !== false (stricter,
  excludes users with unset accountEnabled)
- Update doc comments to mention client-side filtering and remove
  accountEnabled from the filter example
- Update changeset to mention userGroupMemberSearch exclusivity
- Add accountEnabled: true to test mocks
- Add regression tests for disabled user filtering

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2026-05-28 15:33:08 +02:00
Fredrik Adelöw 8930d77157 fix(catalog-backend-module-msgraph): filter disabled users client-side
Revert the server-side accountEnabled base filter from #34165 which
broke the group members endpoint. Filter disabled users client-side
in both the /users and group members paths. Restore the mutual
exclusivity check between userFilter and userGroupMemberFilter.

Fixes #34422

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2026-05-28 15:24:48 +02:00
Fredrik Adelöw 2d181c035d Add changeset
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2026-05-27 22:37:22 +02:00
James Brooks b33bb24b5a Add NumberField component to @backstage/ui (#34264)
* Add NumberField component to @backstage/ui

Signed-off-by: James Brooks <jamesbrooks@spotify.com>

* Address review feedback on NumberField

Signed-off-by: James Brooks <jamesbrooks@spotify.com>

* Fix NumberField CSS formatting

Signed-off-by: James Brooks <jamesbrooks@spotify.com>

* Add increment/decrement buttons to NumberField

Signed-off-by: James Brooks <jamesbrooks@spotify.com>

* Fix NumberField looking disabled at min/max bounds

Signed-off-by: James Brooks <jamesbrooks@spotify.com>

---------

Signed-off-by: James Brooks <jamesbrooks@spotify.com>
2026-05-27 17:20:27 +02:00
Fredrik Adelöw 58fb313f22 Merge pull request #34398 from robingileborg/master
Bitbucket username should not be treated as a secret
2026-05-27 16:29:50 +02:00
Fredrik Adelöw 5aa867c86f Merge pull request #34416 from backstage/freben/fix-missing-runtime-deps
fix: restore runtime dependencies incorrectly demoted to devDependencies
2026-05-27 15:30:53 +02:00
Fredrik Adelöw 150f290178 Merge pull request #31613 from backstage/renovate/azure-sdk-for-js-monorepo
chore(deps): update azure-sdk-for-js monorepo
2026-05-27 14:55:44 +02:00
Fredrik Adelöw 378784ebf0 fix: restore runtime dependencies incorrectly demoted to devDependencies
PR #33936 removed duplicate dependency entries, but in two cases moved
deps from dependencies to devDependencies that are still re-exported in
the published API reports:

- @backstage/catalog-client: @backstage/plugin-catalog-common
  (AnalyzeLocationRequest/AnalyzeLocationResponse types)
- @backstage/frontend-plugin-api: @backstage/config (Config type)

These need to be runtime dependencies so consumers can resolve the
types at build time.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2026-05-27 14:51:28 +02:00
Stijn Brouwers 34f21c39a5 chore(changeset): Add PR changeset
Signed-off-by: Stijn Brouwers <stijn@bdcommit.com>
2026-05-27 14:32:51 +02:00
Charles de Dreuille 9f1dd4ae9b docs(ui): expand neutral background migration notes
Add full shift mapping (old --bui-bg-neutral-1..4 → new --bui-bg-neutral-2..5)
to the changeset, ESLint rule docs, and PR description so adopters
understand the complete renaming of the neutral background scale.

Signed-off-by: Charles de Dreuille <charles.dedreuille@gmail.com>
2026-05-27 13:14:30 +02:00
Charles de Dreuille 657aad6cf0 refactor(ui): rename surface tokens to neutral background tokens
Replace --bui-surface-1..5 with --bui-bg-neutral-1..5 for both light
and dark themes. --bui-bg-neutral-1 replaces the deprecated --bui-bg-app,
and --bui-bg-neutral-2..5 extend the scale. The old bare --bui-bg-neutral-1..4
entries are removed from the deprecated section since their names are now
reused; the hover/pressed/disabled variants remain deprecated.

Updates colors.stories.tsx, the ESLint rule and tests, and all migration
documentation and the PR description accordingly.

Signed-off-by: Charles de Dreuille <charles.dedreuille@gmail.com>
2026-05-27 13:11:38 +02:00
Charles de Dreuille 1caf3573fa docs(ui): reformat changeset to follow ui changeset conventions
Replace markdown headings with bold markers and add Affected components
line as required by the .changeset/README.md format guide.

Signed-off-by: Charles de Dreuille <charles.dedreuille@gmail.com>
2026-05-26 21:39:34 +02:00
Charles de Dreuille 4d223156a2 docs(ui): add full migration table to changeset
Maps every deprecated token to its semantic replacement, grouped by
family: Surfaces, Foreground, Accent, Positive, Negative, Warning,
and Announcement.

Signed-off-by: Charles de Dreuille <charles.dedreuille@gmail.com>
2026-05-26 21:29:47 +02:00
Charles de Dreuille 5d80f77e43 chore: add changesets and fix colors story layout
- Add patch changeset for @backstage/ui (new semantic color token families)
- Add patch changeset for @backstage/eslint-plugin (no-deprecated-bui-tokens rule)
- Remove redundant wrapper div in the Colors story and drop minHeight
  that was preventing scroll in the Storybook canvas

Signed-off-by: Charles de Dreuille <charles.dedreuille@gmail.com>
2026-05-26 21:25:52 +02:00
Patrik Oldsberg ada73f2ba4 Merge pull request #31466 from jescalada/31624-fix-autologout-bug
fix: auto-logout not working when closing tabs and reopening
2026-05-26 18:13:26 +02:00
github-actions[bot] 68db890456 Version Packages (next) 2026-05-26 15:26:38 +00:00
Fredrik Adelöw b75158b2c1 chore: add changeset for Azure SDK test fixes
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2026-05-26 17:18:31 +02:00
Rickard Dybeck c4f935b805 chore(kubernetes-backend): create missing changeset
create missing changeset for #34344

Signed-off-by: Rickard Dybeck <dybeck@spotify.com>
2026-05-26 09:59:18 -04:00
Fredrik Adelöw e223e89103 Merge pull request #34291 from backstage/freben/split-count-frontend
catalog-react: split entity list and count into parallel requests
2026-05-26 14:48:06 +02:00
Fredrik Adelöw 40e3e0e24d Merge pull request #34214 from backstage/freben/queryentities-total-items
catalog-backend: split queryEntities list + count, add totalItems mode
2026-05-26 14:47:46 +02:00
Fredrik Adelöw af8b07e602 Merge pull request #34339 from backstage/freben/stitch-queue-no-overlap
fix(catalog-backend): prevent overlapping stitches for the same entity
2026-05-26 14:46:59 +02:00
Fredrik Adelöw 877f528cfd Merge pull request #34315 from backstage/freben/search-extended-statistics
Add extended statistics on search(key, value) for query planner accuracy
2026-05-26 14:46:50 +02:00
Fredrik Adelöw f1918e1b64 Merge pull request #34193 from backstage/freben/remove-immediate-stitching
catalog-backend: remove immediate mode stitching
2026-05-26 14:46:15 +02:00
Fredrik Adelöw 0f5286f23c Merge pull request #34393 from backstage/freben/protojs
try to remove protojs pins
2026-05-26 14:46:01 +02:00
Robin Gileborg 241d359913 Bitbucket username should not be treated as a secret
Signed-off-by: Robin Gileborg <robin@gileborg.com>
2026-05-26 13:19:08 +02:00
Fredrik Adelöw a1971eace8 chore: add changeset for protobufjs warning suppression
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2026-05-26 11:42:53 +02:00
benjdlambert f2d71d1d48 Add tests for public entry point and rename config to disablePublicEntryPoint
Signed-off-by: benjdlambert <ben@blam.sh>
2026-05-26 10:43:45 +02:00
benjdlambert ca450bec54 Add config to disable experimental public entry point
Signed-off-by: benjdlambert <ben@blam.sh>
2026-05-26 10:33:37 +02:00
Andre Wanlin 850f7c2ce5 Merge pull request #33359 from awanlin/topic/typos-cli
Added `typos` to CI and fixed all findings
2026-05-25 15:23:38 -05:00
Fredrik Adelöw 9af020191e Merge pull request #34317 from backstage/freben/fix-entity-page-test-flake
fix(catalog): fix flaky entity page test
2026-05-25 16:00:49 +02:00
Andre Wanlin 8b31484e82 Merge pull request #33690 from asheen1234/gitlab-repo-owner-picker
Add GitLabRepoOwnerPicker for RepoOwnerPicker
2026-05-25 09:00:36 -05:00
Fredrik Adelöw b304686e03 Merge pull request #34353 from officialasishkumar/fix-rate-limit-ipv6-key-generator
fix(backend-defaults): use ipKeyGenerator for rate limiter keys
2026-05-25 15:40:43 +02:00
Fredrik Adelöw 23686b5095 Update changeset and PR description
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2026-05-25 15:24:02 +02:00
Fredrik Adelöw 4b0ad7b0b5 Merge pull request #34351 from backstage/dependabot/npm_and_yarn/qs-6.15.2
chore(deps): bump qs from 6.15.1 to 6.15.2
2026-05-25 13:29:33 +02:00
Vincenzo Scamporlino bfef8b7b20 Merge pull request #34327 from backstage/unprocessed-entities
Unprocessed entities: update installation instructions
2026-05-25 12:46:21 +02:00
Fredrik Adelöw 17cce350b3 Merge pull request #34219 from backstage/renovate/embedded-postgres-18.x
Update dependency embedded-postgres to v18.3.0-beta.17
2026-05-25 12:09:39 +02:00
Fredrik Adelöw 6fdfcb3cb0 Merge pull request #34306 from backstage/dependabot/npm_and_yarn/ws-8.20.1
chore(deps): Bump ws from 8.20.0 to 8.20.1
2026-05-25 12:03:16 +02:00
Asish Kumar 8add9b992d fix(core-components): decode url-safe base64 tokens in proxy sign-in
The proxy-based sign-in page derived the session expiry from the JWT by
decoding its payload with `window.atob`, which only accepts the standard
base64 alphabet. JWTs are encoded using base64url (RFC 7515), so any
token whose payload contained '-' or '_' raised a decoding error and
broke sign-in. Translate the payload back to the standard alphabet and
restore its padding before decoding.

Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
2026-05-25 05:30:56 +05:30
Asish Kumar def82d4d5e fix(backend-defaults): use ipKeyGenerator for rate limiter keys
The built-in rate limiter derived its key directly from `req.ip`, which
express-rate-limit 8.x rejects with an ERR_ERL_KEY_GEN_IPV6 validation
error. A raw IPv6 address used as a rate limiting key would let a client
bypass the limit by rotating through addresses in its allotted block, so
the library now requires its `ipKeyGenerator` helper to normalize the
address. Wrap the resolved client address in that helper so the limiter
starts cleanly and groups IPv6 clients by their address block.

Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
2026-05-25 05:21:28 +05:30
dependabot[bot] e0889a3f8e chore(deps): bump qs from 6.15.1 to 6.15.2
Bumps [qs](https://github.com/ljharb/qs) from 6.15.1 to 6.15.2.
- [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md)
- [Commits](https://github.com/ljharb/qs/compare/v6.15.1...v6.15.2)

---
updated-dependencies:
- dependency-name: qs
  dependency-version: 6.15.2
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-05-23 12:27:32 +00:00
Adam Letizia e846874385 fix(catalog-incremental): use text for ingestions.last_error column type
Signed-off-by: Adam Letizia <LetiziaAdam@JohnDeere.com>
2026-05-22 14:21:55 -05:00
Fredrik Adelöw 0b8b67767b fix(catalog-backend): prevent overlapping stitches for the same entity
markForStitching now only updates the ticket on conflict, leaving
next_stitch_at unchanged so an in-progress worker isn't interrupted.

markDeferredStitchCompleted bumps next_stitch_at to now() when the
ticket changed, so pending re-stitches happen immediately after the
current stitch finishes rather than waiting for the timeout.

performStitching no longer calls markDeferredStitchCompleted when
abandoned due to a stale ticket, since the queue entry belongs to
another worker.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2026-05-22 16:57:53 +02:00