paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 48 Packages Projects Releases Wiki Activity

Merge pull request #34393 from backstage/freben/protojs

Browse Source 
try to remove protojs pins
This commit is contained in:
Fredrik Adelöw
2026-05-26 14:46:01 +02:00
committed by GitHub
parent df6fc9d2cf eca61bc02e
commit 0f5286f23c
3 changed files with 26 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.changeset/remove-protobufjs-pins.md
+5
View File
@@ -0,0 +1,5 @@
---
'@backstage/cli-module-build': patch
---
Suppress false-positive `@protobufjs/inquire` "Critical dependency" warning in the bundler. Since `protobufjs` 7.5.9, the dynamic require path in inquire is no longer exercised, but webpack/rspack still flags it during static analysis.
packages/cli-module-build/src/lib/bundler/config.ts
+21 -8
View File
@@ -394,16 +394,29 @@ export async function createConfig(
}),
},
plugins,
...(options.moduleFederationRemote && {
ignoreWarnings: [
// @protobufjs/inquire uses require(moduleName) with a dynamic argument.
// Since protobufjs >=7.5.9 this code path is never exercised (the
// bundler-safe optional module lookups backport replaced all call sites),
// but webpack/rspack still statically analyzes the source and emits a
// "Critical dependency" warning. Safe to suppress.
// See https://github.com/protobufjs/protobuf.js/issues/2057
{
module: /@protobufjs[\\/]inquire/,
message:
/Critical dependency: the request of a dependency is an expression/,
},
// TODO: remove this warning skipping as soon as the corresponding bundler limitation
// described in issue https://github.com/web-infra-dev/rspack/issues/13635 is fixed
// when PR: https://github.com/web-infra-dev/rspack/pull/13636 is merged.
ignoreWarnings: [
{
message:
/No version specified and unable to automatically determine one\. No version in description file/,
},
],
}),
...(options.moduleFederationRemote
? [
{
message:
/No version specified and unable to automatically determine one\. No version in description file/,
},
]
: []),
],
};
}
packages/create-app/seed-yarn.lock
-43
View File
@@ -37,46 +37,3 @@ fast-xml-builder@*:
version "3.1.0"
resolved "https://registry.yarnpkg.com/knex/-/knex-3.1.0.tgz#b6ddd5b5ad26a6315234a5b09ec38dc4a370bd8c"
integrity sha512-GLoII6hR0c4ti243gMs5/1Rb3B+AjwMOfjYm97pu0FOQa7JH56hgBxYf5WK2525ceSbBY1cjeZ9yk99GPMB6Kw==
// @protobufjs/inquire@1.1.1 dropped the eval-based workaround that hid its
// dynamic require() from bundlers, which causes webpack/rspack to emit a
// "Critical dependency: the request of a dependency is an expression" warning
// that fails the build under CI=true. Pin to 1.1.0 until upstream is fixed.
// See https://github.com/protobufjs/protobuf.js/issues/2057
"@protobufjs/inquire@^1.1.0":
version "1.1.0"
resolved "https://registry.yarnpkg.com/@protobufjs/inquire/-/inquire-1.1.0.tgz#ff200e3e7cf2429e2dcafc1140828e8cc638f089"
integrity sha512-kdSefcPdruJiFMVSbn801t4vFK7KB/5gd2fYvrxhuJYg8ILrmn9SKSX2tZdV6V+ksulWqS7aXjBcRXl3wHoD9Q==
// protobufjs@7.5.6 bumped its @protobufjs/inquire dependency to ^1.1.1, which
// would bypass the pin above. Pin protobufjs to 7.5.5 (the last version that
// requests inquire ^1.1.0) for all known workspace queries.
"protobufjs@^7.0.0":
version "7.5.5"
resolved "https://registry.yarnpkg.com/protobufjs/-/protobufjs-7.5.5.tgz#b7089ca4410374c75150baf277353ef76db69f96"
integrity sha512-3wY1AxV+VBNW8Yypfd1yQY9pXnqTAN+KwQxL8iYm3/BjKYMNg4i0owhEe26PWDOMaIrzeeF98Lqd5NGz4omiIg==
"protobufjs@^7.2.5":
version "7.5.5"
resolved "https://registry.yarnpkg.com/protobufjs/-/protobufjs-7.5.5.tgz#b7089ca4410374c75150baf277353ef76db69f96"
integrity sha512-3wY1AxV+VBNW8Yypfd1yQY9pXnqTAN+KwQxL8iYm3/BjKYMNg4i0owhEe26PWDOMaIrzeeF98Lqd5NGz4omiIg==
"protobufjs@^7.2.6":
version "7.5.5"
resolved "https://registry.yarnpkg.com/protobufjs/-/protobufjs-7.5.5.tgz#b7089ca4410374c75150baf277353ef76db69f96"
integrity sha512-3wY1AxV+VBNW8Yypfd1yQY9pXnqTAN+KwQxL8iYm3/BjKYMNg4i0owhEe26PWDOMaIrzeeF98Lqd5NGz4omiIg==
"protobufjs@^7.3.2":
version "7.5.5"
resolved "https://registry.yarnpkg.com/protobufjs/-/protobufjs-7.5.5.tgz#b7089ca4410374c75150baf277353ef76db69f96"
integrity sha512-3wY1AxV+VBNW8Yypfd1yQY9pXnqTAN+KwQxL8iYm3/BjKYMNg4i0owhEe26PWDOMaIrzeeF98Lqd5NGz4omiIg==
"protobufjs@^7.4.0":
version "7.5.5"
resolved "https://registry.yarnpkg.com/protobufjs/-/protobufjs-7.5.5.tgz#b7089ca4410374c75150baf277353ef76db69f96"
integrity sha512-3wY1AxV+VBNW8Yypfd1yQY9pXnqTAN+KwQxL8iYm3/BjKYMNg4i0owhEe26PWDOMaIrzeeF98Lqd5NGz4omiIg==
"protobufjs@^7.5.3":
version "7.5.5"
resolved "https://registry.yarnpkg.com/protobufjs/-/protobufjs-7.5.5.tgz#b7089ca4410374c75150baf277353ef76db69f96"
integrity sha512-3wY1AxV+VBNW8Yypfd1yQY9pXnqTAN+KwQxL8iYm3/BjKYMNg4i0owhEe26PWDOMaIrzeeF98Lqd5NGz4omiIg==