Merge pull request #28792 from stephenglass/fix-starred-entities-display

fix(home): fix home starred entities not using `title` or `displayName`

.changeset/cyan-needles-hear.md

@@ -0,0 +1,5 @@
+---
+'@backstage/plugin-home': patch
+---
+
+The starred entities component uses the entity title or display name if it exists

plugins/home/src/homePageComponents/StarredEntities/Content.test.tsx

@@ -50,7 +50,24 @@ describe('StarredEntitiesContent', () => {
     mockedApi.toggleStarred('component:default/mock-starred-entity-2');
     mockedApi.toggleStarred('component:default/mock-starred-entity-3');
 
-    const mockCatalogApi = catalogApiMock({ entities });
+    const mockCatalogApi = catalogApiMock.mock({
+      getEntitiesByRefs: jest.fn().mockImplementation(async ({ fields }) => {
+        const expectedFields = [
+          'kind',
+          'metadata.namespace',
+          'metadata.name',
+          'spec.type',
+          'metadata.title',
+          'spec.profile.displayName',
+        ];
+        expectedFields.forEach(field => {
+          expect(fields).toContain(field);
+        });
+        return {
+          items: entities,
+        };
+      }),
+    });
 
     const { getByText, queryByText } = await renderInTestApp(
       <TestApiProvider

plugins/home/src/homePageComponents/StarredEntities/Content.tsx

@@ -73,7 +73,14 @@ export const Content = ({
     return (
       await catalogApi.getEntitiesByRefs({
         entityRefs: [...starredEntities],
-        fields: ['kind', 'metadata.namespace', 'metadata.name', 'spec.type'],
+        fields: [
+          'kind',
+          'metadata.namespace',
+          'metadata.name',
+          'spec.type',
+          'metadata.title',
+          'spec.profile.displayName',
+        ],
       })
     ).items.filter((e): e is Entity => !!e);
   }, [catalogApi, starredEntities]);