paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 39 Packages Projects Releases Wiki Activity

Merge pull request #844 from spotify/rugvip/release-fix

Browse Source 
packages/cli: fix create-app package resolution in e2e test mode
This commit is contained in:
Patrik Oldsberg
2020-05-13 15:53:41 +02:00
committed by GitHub
parent 9c4317ea39 29abee4c31
commit fb54d1d300
1 changed files with 29 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/cli/src/commands/create-app/createApp.ts
+29 -15
View File
@@ -88,25 +88,39 @@ export async function moveApp(
async function addPackageResolutions(appDir: string) {
const pkgJsonPath = resolvePath(appDir, 'package.json');
const packageFileContent = await fs.readFile(pkgJsonPath, 'utf-8');
const packageFileJson = JSON.parse(packageFileContent);
const pkgJson = await fs.readJson(pkgJsonPath);
packageFileJson.resolutions = packageFileJson.resolutions || {};
pkgJson.resolutions = pkgJson.resolutions || {};
pkgJson.dependencies = pkgJson.dependencies || {};
const packages = ['cli', 'core', 'test-utils', 'test-utils-core', 'theme'];
const depNames = [
'cli',
'core',
'dev-utils',
'test-utils',
'test-utils-core',
'theme',
];
for (const pkg of packages) {
await Task.forItem('adding', `${pkg} link to package.json`, async () => {
const pkgPath = paths.resolveOwnRoot('packages', pkg);
packageFileJson.resolutions[`@backstage/${pkg}`] = `file:${pkgPath}`;
const newContents = `${JSON.stringify(packageFileJson, null, 2)}\n`;
for (const name of depNames) {
await Task.forItem(
'adding',
`@backstage/${name} link to package.json`,
async () => {
const pkgPath = paths.resolveOwnRoot('packages', name);
// Add to both resolutions and dependencies, or transitive dependencies will still be fetched from the registry.
pkgJson.dependencies[`@backstage/${name}`] = `file:${pkgPath}`;
pkgJson.resolutions[`@backstage/${name}`] = `file:${pkgPath}`;
await fs.writeFile(pkgJsonPath, newContents, 'utf-8').catch((error) => {
throw new Error(
`Failed to add resolutions to package.json: ${error.message}`,
);
});
});
await fs
.writeJSON(pkgJsonPath, pkgJson, { encoding: 'utf8', spaces: 2 })
.catch((error) => {
throw new Error(
`Failed to add resolutions to package.json: ${error.message}`,
);
});
},
);
}
}