paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 48 Packages Projects Releases Wiki Activity

Merge pull request #163 from spotify/rugvip/green-check

Browse Source 
cli/createPlugin: fix color inconsistency for check marks
This commit is contained in:
Patrik Oldsberg
2020-03-05 11:07:42 +01:00
committed by GitHub
parent 34a6708780 1c9480a4a0
commit f8895a6395
1 changed files with 11 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/packages/cli/src/commands/createPlugin.ts
+11 -8
View File
@@ -7,6 +7,9 @@ import recursive from 'recursive-readdir';
import { promisify } from 'util';
import { exec } from 'child_process';
const MARKER_SUCCESS = chalk.green(` ✓\n`);
const MARKER_FAILURE = chalk.red(` ✗\n`);
export const createPluginFolder = (rootDir: string, id: string): string => {
console.log();
console.log(chalk.green(' Creating the plugin directory:'));
@@ -54,9 +57,9 @@ export const createFileFromTemplate = (
});
try {
fs.writeFileSync(destination, contents);
process.stdout.write(chalk.green(` ✓\n`));
process.stdout.write(MARKER_SUCCESS);
} catch (e) {
process.stdout.write(chalk.red(` ✗\n`));
process.stdout.write(MARKER_FAILURE);
throw new Error(`Failed to create file: ${destination}: ${e.message}`);
}
};
@@ -170,9 +173,9 @@ export const createFromTemplateDir = async (
} else {
try {
fs.copyFileSync(file, file.replace(templateFolder, destinationFolder));
process.stdout.write(chalk.green(` ✓\n`));
process.stdout.write(MARKER_SUCCESS);
} catch (e) {
process.stdout.write(chalk.red(` ✗\n`));
process.stdout.write(MARKER_FAILURE);
throw new Error(
`Failed to copy file: ${file.replace(
templateFolder,
@@ -213,10 +216,10 @@ const cleanUp = async (rootDir: string, id: string) => {
try {
// Not using recursion here, so only empty directories can be removed
fs.rmdirSync(destination);
process.stdout.write(chalk.green(` ✓\n`));
process.stdout.write(MARKER_SUCCESS);
console.log();
} catch (e) {
process.stdout.write(chalk.red(` ✗\n`));
process.stdout.write(MARKER_FAILURE);
console.log();
console.log(chalk.red(`Failed to cleanup: ${e.message}`));
}
@@ -235,9 +238,9 @@ const buildPlugin = async (pluginFolder: string) => {
try {
process.chdir(pluginFolder);
await prom_exec(command, { timeout: 60000 });
process.stdout.write(chalk.cyan(` ✓\n`));
process.stdout.write(MARKER_SUCCESS);
} catch (e) {
process.stdout.write(chalk.red(` ✗\n`));
process.stdout.write(MARKER_FAILURE);
throw new Error(
`Could not execute command ${chalk.cyan(command)}: ${e.message}`,
);