address review comments

Signed-off-by: Kashish Mittal <kmittal@redhat.com>

plugins/scaffolder-backend/report-alpha.api.md

@@ -11,6 +11,7 @@ import { PermissionCriteria } from '@backstage/plugin-permission-common';
 import { PermissionRule } from '@backstage/plugin-permission-node';
 import { ResourcePermission } from '@backstage/plugin-permission-common';
 import { SerializedTask } from '@backstage/plugin-scaffolder-node';
+import { TaskFilter } from '@backstage/plugin-scaffolder-node';
 import { TemplateEntityStepV1beta3 } from '@backstage/plugin-scaffolder-common';
 import { TemplateParametersV1beta3 } from '@backstage/plugin-scaffolder-common';
 
@@ -87,10 +88,7 @@ export const scaffolderActionConditions: Conditions<{
 export const scaffolderTaskConditions: Conditions<{
   isTaskOwner: PermissionRule<
     SerializedTask,
-    {
-      key: string;
-      values: any;
-    },
+    TaskFilter,
     'scaffolder-task',
     {
       createdBy: string[];

plugins/scaffolder-backend/src/service/rules.ts

@@ -27,7 +27,7 @@ import {
   TemplateParametersV1beta3,
 } from '@backstage/plugin-scaffolder-common';
 
-import { SerializedTask } from '@backstage/plugin-scaffolder-node';
+import { SerializedTask, TaskFilter } from '@backstage/plugin-scaffolder-node';
 
 import { z } from 'zod';
 import { JsonObject, JsonPrimitive } from '@backstage/types';
@@ -135,10 +135,7 @@ function buildHasProperty<Schema extends z.ZodType<JsonPrimitive>>({
 
 export const createTaskPermissionRule = makeCreatePermissionRule<
   SerializedTask,
-  {
-    key: string;
-    values: any;
-  },
+  TaskFilter,
   typeof RESOURCE_TYPE_SCAFFOLDER_TASK
 >();