Adjust props to fit general conventions

Signed-off-by: Philipp Hugenroth <philipph@spotify.com>

packages/core-components/api-report.md

@@ -1202,7 +1202,7 @@ export const Page: ({
   children,
 }: PropsWithChildren<Props_21>) => JSX.Element;
 
-// Warning: (ae-forgotten-export) The symbol "ThemedHeaderProps" needs to be exported by the entry point index.d.ts
+// Warning: (ae-forgotten-export) The symbol "PageWithHeaderProps" needs to be exported by the entry point index.d.ts
 // Warning: (ae-missing-release-tag) "PageWithHeader" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
 //
 // @public (undocumented)
@@ -1210,7 +1210,7 @@ export const PageWithHeader: ({
   themeId,
   children,
   ...props
-}: PropsWithChildren<ThemedHeaderProps>) => JSX.Element;
+}: PropsWithChildren<PageWithHeaderProps>) => JSX.Element;
 
 // Warning: (ae-missing-release-tag) "Progress" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
 //

packages/core-components/src/layout/Page/PageWithHeader.tsx

@@ -19,7 +19,7 @@ import React, { PropsWithChildren, ComponentProps } from 'react';
 import { Header } from '../Header';
 import { Page } from './Page';
 
-export type ThemedHeaderProps = ComponentProps<typeof Header> & {
+type PageWithHeaderProps = ComponentProps<typeof Header> & {
   themeId: string;
 };
 
@@ -27,7 +27,7 @@ export const PageWithHeader = ({
   themeId,
   children,
   ...props
-}: PropsWithChildren<ThemedHeaderProps>) => (
+}: PropsWithChildren<PageWithHeaderProps>) => (
   <Page themeId={themeId}>
     <Header {...props} />
     {children}

plugins/catalog/api-report.md

@@ -288,7 +288,7 @@ export const EntitySystemDiagramCard: SystemDiagramCard;
 // @public (undocumented)
 export const FilterContainer: ({
   children,
-}: React_2.PropsWithChildren<{}>) => JSX.Element;
+}: PropsWithChildren<{}>) => JSX.Element;
 
 // Warning: (ae-missing-release-tag) "FilteredEntityLayout" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
 //

plugins/catalog/src/components/FilteredEntityLayout/FilterContainer.tsx

@@ -25,9 +25,9 @@ import {
   useTheme,
 } from '@material-ui/core';
 import FilterListIcon from '@material-ui/icons/FilterList';
-import React, { useState } from 'react';
+import React, { useState, PropsWithChildren } from 'react';
 
-export const FilterContainer = ({ children }: React.PropsWithChildren<{}>) => {
+export const FilterContainer = ({ children }: PropsWithChildren<{}>) => {
   const isMidSizeScreen = useMediaQuery<BackstageTheme>(theme =>
     theme.breakpoints.down('md'),
   );