auth-backend: move logger setup out from constructors and use non-reserved fields

plugins/auth-backend/src/identity/TokenFactory.ts

@@ -39,11 +39,10 @@ export class TokenFactory implements TokenIssuer {
   private privateKeyPromise?: Promise<JSONWebKey>;
 
   constructor(options: Options) {
-    const { issuer, logger, keyStore, keyDuration } = options;
-    this.issuer = issuer;
-    this.keyStore = keyStore;
-    this.keyDuration = keyDuration;
-    this.logger = logger.child({ service: 'issuer' });
+    this.issuer = options.issuer;
+    this.logger = options.logger;
+    this.keyStore = options.keyStore;
+    this.keyDuration = options.keyDuration;
   }
 
   async issueToken(claims: TokenParams): Promise<string> {

plugins/auth-backend/src/identity/router.ts

@@ -25,12 +25,7 @@ export type Options = {
 };
 
 export function createOidcRouter(options: Options) {
-  const {
-    logger: baseLogger,
-    keyStore,
-    baseUrl = 'http://localhost:7000/auth',
-  } = options;
-  const logger = baseLogger.child({ router: 'identity' });
+  const { logger, keyStore, baseUrl } = options;
 
   const router = Router();
 

plugins/auth-backend/src/service/router.ts

@@ -41,13 +41,13 @@ export async function createRouter(
 
   const keyStore = await DatabaseKeyStore.create({
     database: options.database,
-    logger,
+    logger: logger.child({ component: 'db-key-store' }),
     keyDuration,
   });
   const issuer = new TokenFactory({
     issuer: baseUrl,
     keyStore,
-    logger,
+    logger: logger.child({ component: 'token-factory' }),
     keyDuration,
   });
 
@@ -112,7 +112,13 @@ export async function createRouter(
     }
   }
 
-  router.use(createOidcRouter({ logger, keyStore, baseUrl }));
+  router.use(
+    createOidcRouter({
+      logger: logger.child({ component: 'oidc-router' }),
+      keyStore,
+      baseUrl,
+    }),
+  );
 
   return router;
 }