Merge pull request #6024 from goober/bugfix/jenkins-builds-with-slashes

[jenkins-plugin] Support Jenkins build details for branches that contains slashes
This commit is contained in:
Patrik Oldsberg
2021-06-16 18:07:07 +02:00
committed by GitHub
3 changed files with 9 additions and 2 deletions
+5
View File
@@ -0,0 +1,5 @@
---
'@backstage/plugin-jenkins': patch
---
Support showing build details for branches with slashes in their names
@@ -50,7 +50,9 @@ const BuildWithStepsView = () => {
const projectName = useProjectSlugFromEntity();
const { branch, buildNumber } = useRouteRefParams(buildRouteRef);
const classes = useStyles();
const buildPath = `${projectName}/${branch}/${buildNumber}`;
const buildPath = `${projectName}/${encodeURIComponent(
branch,
)}/${buildNumber}`;
const [{ value }] = useBuildWithSteps(buildPath);
return (
@@ -118,7 +118,7 @@ const generatedColumns: TableColumn[] = [
<Link
component={RouterLink}
to={generatePath(buildRouteRef.path, {
branch: row.source.branchName,
branch: encodeURIComponent(row.source.branchName),
buildNumber: row.buildNumber.toString(),
})}
>