Merge pull request #18045 from kuangp/fix/githubMultiOrgEntityProvider

fix(GithubMultiOrgEntityProvider): add missing await

.changeset/rare-bugs-chew.md

@@ -0,0 +1,5 @@
+---
+'@backstage/plugin-catalog-backend-module-github': patch
+---
+
+Properly handle `async` event callback

plugins/catalog-backend-module-github/src/providers/GithubMultiOrgEntityProvider.test.ts

@@ -1694,7 +1694,6 @@ describe('GithubMultiOrgEntityProvider', () => {
             },
           },
         });
-        await new Promise(process.nextTick);
 
         expect(entityProviderConnection.applyMutation).toHaveBeenCalledTimes(1);
         expect(entityProviderConnection.applyMutation).toHaveBeenCalledWith({
@@ -1867,7 +1866,6 @@ describe('GithubMultiOrgEntityProvider', () => {
             },
           },
         });
-        await new Promise(process.nextTick);
 
         expect(entityProviderConnection.applyMutation).toHaveBeenCalledTimes(1);
         expect(entityProviderConnection.applyMutation).toHaveBeenCalledWith({

plugins/catalog-backend-module-github/src/providers/GithubMultiOrgEntityProvider.ts

@@ -388,7 +388,10 @@ export class GithubMultiOrgEntityProvider implements EntityProvider {
 
     // https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#membership
     if (params.topic.includes('membership')) {
-      this.onMembershipChangedInTeam(eventPayload as MembershipEvent, orgs);
+      await this.onMembershipChangedInTeam(
+        eventPayload as MembershipEvent,
+        orgs,
+      );
     }
 
     return;