paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 29 Packages Projects Releases Wiki Activity

Remove try-catch blocks from tests

Browse Source 
Signed-off-by: Kevin Snyder <kevin.snyder@gusto.com>
This commit is contained in:
Kevin Snyder
2025-04-15 11:03:30 -07:00
parent 6579c2c294
commit e9fda13083
11 changed files with 37 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/scaffolder-backend-module-github/src/actions/github.test.ts
+7 -5
View File
@@ -140,11 +140,13 @@ describe('publish:github', () => {
afterEach(jest.resetAllMocks);
it('should pass context logger to Octokit client', async () => {
try {
await action.handler(mockContext);
} catch (e) {
// no-op
}
mockOctokit.rest.users.getByUsername.mockResolvedValue({
data: { type: 'Organization' },
});
mockOctokit.rest.repos.createInOrg.mockResolvedValue({ data: {} });
await action.handler(mockContext);
expect(octokitMock).toHaveBeenCalledWith(
expect.objectContaining({ log: mockContext.logger }),
plugins/scaffolder-backend-module-github/src/actions/githubActionsDispatch.test.ts
+1 -5
View File
@@ -72,11 +72,7 @@ describe('github:actions:dispatch', () => {
});
it('should pass context logger to Octokit client', async () => {
try {
await action.handler(mockContext);
} catch (e) {
// no-op
}
await action.handler(mockContext);
expect(octokitMock).toHaveBeenCalledWith(
expect.objectContaining({ log: mockContext.logger }),
plugins/scaffolder-backend-module-github/src/actions/githubAutolinks.test.ts
+1 -5
View File
@@ -71,11 +71,7 @@ describe('github:autolinks:create', () => {
workspacePath,
});
try {
await action.handler(mockContext);
} catch (e) {
// no-op
}
await action.handler(mockContext);
expect(octokitMock).toHaveBeenCalledWith(
expect.objectContaining({ log: mockContext.logger }),
plugins/scaffolder-backend-module-github/src/actions/githubBranchProtection.test.ts
+1 -5
View File
@@ -73,11 +73,7 @@ describe('github:branch-protection:create', () => {
afterEach(jest.resetAllMocks);
it('should pass context logger to Octokit client', async () => {
try {
await action.handler(mockContext);
} catch (e) {
// no-op
}
await action.handler(mockContext);
expect(octokitMock).toHaveBeenCalledWith(
expect.objectContaining({ log: mockContext.logger }),
plugins/scaffolder-backend-module-github/src/actions/githubDeployKey.test.ts
+8 -5
View File
@@ -73,11 +73,14 @@ describe('github:deployKey:create', () => {
});
it('should pass context logger to Octokit client', async () => {
try {
await action.handler(mockContext);
} catch (e) {
// no-op
}
mockOctokit.rest.actions.getRepoPublicKey.mockResolvedValue({
data: {
key: publicKey,
key_id: 'keyid',
},
});
await action.handler(mockContext);
expect(octokitMock).toHaveBeenCalledWith(
expect.objectContaining({ log: mockContext.logger }),
plugins/scaffolder-backend-module-github/src/actions/githubEnvironment.test.ts
+1 -5
View File
@@ -141,11 +141,7 @@ describe('github:environment:create', () => {
afterEach(jest.resetAllMocks);
it('should pass context logger to Octokit client', async () => {
try {
await action.handler(mockContext);
} catch (e) {
// no-op
}
await action.handler(mockContext);
expect(octokitMock).toHaveBeenCalledWith(
expect.objectContaining({ log: mockContext.logger }),
plugins/scaffolder-backend-module-github/src/actions/githubIssuesLabel.test.ts
+1 -5
View File
@@ -80,11 +80,7 @@ describe('github:issues:label', () => {
});
it('should pass context logger to Octokit client', async () => {
try {
await action.handler(mockContext);
} catch (e) {
// no-op
}
await action.handler(mockContext);
expect(octokitMock).toHaveBeenCalledWith(
expect.objectContaining({ log: mockContext.logger }),
plugins/scaffolder-backend-module-github/src/actions/githubPagesEnable.test.ts
+1 -5
View File
@@ -73,11 +73,7 @@ describe('github:pages', () => {
afterEach(jest.resetAllMocks);
it('should pass context logger to Octokit client', async () => {
try {
await action.handler(mockContext);
} catch (e) {
// no-op
}
await action.handler(mockContext);
expect(octokitMock).toHaveBeenCalledWith(
expect.objectContaining({ log: mockContext.logger }),
plugins/scaffolder-backend-module-github/src/actions/githubRepoCreate.test.ts
+7 -5
View File
@@ -111,11 +111,13 @@ describe('github:repo:create', () => {
afterEach(jest.resetAllMocks);
it('should pass context logger to Octokit client', async () => {
try {
await action.handler(mockContext);
} catch (e) {
// no-op
}
mockOctokit.rest.users.getByUsername.mockResolvedValue({
data: { type: 'Organization' },
});
mockOctokit.rest.repos.createInOrg.mockResolvedValue({ data: {} });
await action.handler(mockContext);
expect(octokitMock).toHaveBeenCalledWith(
expect.objectContaining({ log: mockContext.logger }),
plugins/scaffolder-backend-module-github/src/actions/githubRepoPush.test.ts
+8 -5
View File
@@ -106,11 +106,14 @@ describe('github:repo:push', () => {
});
it('should pass context logger to Octokit client', async () => {
try {
await action.handler(mockContext);
} catch (e) {
// no-op
}
mockOctokit.rest.repos.get.mockResolvedValue({
data: {
clone_url: 'https://github.com/clone/url.git',
html_url: 'https://github.com/html/url',
},
});
await action.handler(mockContext);
expect(octokitMock).toHaveBeenCalledWith(
expect.objectContaining({ log: mockContext.logger }),
plugins/scaffolder-backend-module-github/src/actions/githubWebhook.test.ts
+1 -5
View File
@@ -73,11 +73,7 @@ describe('github:repository:webhook:create', () => {
});
it('should pass context logger to Octokit client', async () => {
try {
await action.handler(mockContext);
} catch (e) {
// no-op
}
await action.handler(mockContext);
expect(octokitMock).toHaveBeenCalledWith(
expect.objectContaining({ log: mockContext.logger }),