paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 39 Packages Projects Releases Wiki Activity

Merge pull request #1313 from spotify/shmidt-i/fix-hmr

Browse Source 
Fix HMR memoize
This commit is contained in:
Ivan Shmidt
2020-06-16 13:16:26 +02:00
committed by GitHub
parent adf6ea4a87 9050b2011c
commit e67f35b56a
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/backend-common/src/hot.ts
+7 -3
View File
@@ -66,11 +66,11 @@ export function useHotMemoize<T>(
}
// Let's store data per module based on the order of the code invocation
const index = _module.hot.data?.[CURRENT_HOT_MEMOIZE_INDEX_KEY];
const index = _module.hot.data[CURRENT_HOT_MEMOIZE_INDEX_KEY];
// Increasing the counter after each call
_module.hot.data[CURRENT_HOT_MEMOIZE_INDEX_KEY] += 1;
const prevValue = _module.hot.data?.[index];
const prevValue = _module.hot.data[index];
const createDisposeHandler = (value: any) => (data: {
[key: number]: any;
[indexKey: string]: number;
@@ -78,7 +78,11 @@ export function useHotMemoize<T>(
// Preserving the value through the HMR process
data[index] = value;
// Decreasing the counter after each handler
data[CURRENT_HOT_MEMOIZE_INDEX_KEY] = index - 1;
data[CURRENT_HOT_MEMOIZE_INDEX_KEY] =
// First hot update is still different, need to populate the data
typeof data[CURRENT_HOT_MEMOIZE_INDEX_KEY] === 'undefined'
? _module.hot!.data[CURRENT_HOT_MEMOIZE_INDEX_KEY] - 1
: data[CURRENT_HOT_MEMOIZE_INDEX_KEY] - 1;
};
if (prevValue) {