chore: don't deprecate lax on the config commands, and ammend the message that is logged in the console for the deprecations

Signed-off-by: blam <ben@blam.sh>
This commit is contained in:
blam
2021-11-29 14:11:56 +01:00
parent ea99ef5198
commit e1aa50f943
4 changed files with 5 additions and 27 deletions
+3 -1
View File
@@ -26,7 +26,9 @@ export default async (cmd: Command) => {
if (cmd.lax) {
console.warn(
chalk.yellow(
'[DEPRECATED] - The lax argument is deprecated and will be removed in the future.',
`[DEPRECATED] - The --lax option is deprecated and will be removed in the future.
Please open an issue towards https://github.com/backstage/backstage that describes your use-case if you need the flag to stay around
`,
),
);
}
@@ -19,17 +19,8 @@ import { stringify as stringifyYaml } from 'yaml';
import { AppConfig, ConfigReader } from '@backstage/config';
import { loadCliConfig } from '../../lib/config';
import { ConfigSchema, ConfigVisibility } from '@backstage/config-loader';
import chalk from 'chalk';
export default async (cmd: Command) => {
if (cmd.lax) {
console.warn(
chalk.yellow(
'[DEPRECATED] - The lax argument is deprecated and will be removed in the future.',
),
);
}
const { schema, appConfigs } = await loadCliConfig({
args: cmd.config,
fromPackage: cmd.package,
@@ -14,18 +14,10 @@
* limitations under the License.
*/
import chalk from 'chalk';
import { Command } from 'commander';
import { loadCliConfig } from '../../lib/config';
export default async (cmd: Command) => {
if (cmd.lax) {
console.warn(
chalk.yellow(
'[DEPRECATED] - The lax argument is deprecated and will be removed in the future.',
),
);
}
await loadCliConfig({
args: cmd.config,
fromPackage: cmd.package,
+2 -9
View File
@@ -30,7 +30,6 @@ export function registerCommands(program: CommanderStatic) {
.command('app:build')
.description('Build an app for a production release')
.option('--stats', 'Write bundle stats to output directory')
// Deprecated
.option(
'--lax',
'[DEPRECATED] - Do not require environment variables to be set',
@@ -172,10 +171,7 @@ export function registerCommands(program: CommanderStatic) {
'--package <name>',
'Only load config schema that applies to the given package',
)
.option(
'--lax',
'[DEPRECATED] - Do not require environment variables to be set',
)
.option('--lax', 'Do not require environment variables to be set')
.option('--frontend', 'Print only the frontend configuration')
.option('--with-secrets', 'Include secrets in the printed configuration')
.option(
@@ -192,10 +188,7 @@ export function registerCommands(program: CommanderStatic) {
'--package <name>',
'Only load config schema that applies to the given package',
)
.option(
'--lax',
'[DEPRECATED] - Do not require environment variables to be set',
)
.option('--lax', 'Do not require environment variables to be set')
.option('--frontend', 'Only validate the frontend configuration')
.option(...configOption)
.description(