Merge pull request #10460 from backstage/freben/enterpriseInstanceUrl

handle trailing slashes on enterpriseInstanceUrl

.changeset/rotten-planes-watch.md

@@ -0,0 +1,5 @@
+---
+'@backstage/plugin-auth-backend': patch
+---
+
+Handle trailing slashes on GitHub `enterpriseInstanceUrl` settings

plugins/auth-backend/src/providers/github/provider.ts

@@ -318,9 +318,9 @@ export const createGithubProvider = (
     OAuthEnvironmentHandler.mapConfig(config, envConfig => {
       const clientId = envConfig.getString('clientId');
       const clientSecret = envConfig.getString('clientSecret');
-      const enterpriseInstanceUrl = envConfig.getOptionalString(
-        'enterpriseInstanceUrl',
-      );
+      const enterpriseInstanceUrl = envConfig
+        .getOptionalString('enterpriseInstanceUrl')
+        ?.replace(/\/$/, '');
       const customCallbackUrl = envConfig.getOptionalString('callbackUrl');
       const authorizationUrl = enterpriseInstanceUrl
         ? `${enterpriseInstanceUrl}/login/oauth/authorize`