Merge pull request #10250 from backstage/rugvip/title

scaffolder: remove unused titleComponent property
This commit is contained in:
Patrik Oldsberg
2022-03-17 09:56:21 +01:00
committed by GitHub
4 changed files with 7 additions and 6 deletions
+5
View File
@@ -0,0 +1,5 @@
---
'@backstage/plugin-scaffolder': minor
---
**BREAKING**: Removed the unused `titleComponent` property of `groups` passed to the `ScaffolderPage`. The property was already ignored, but existing usage should migrated to use the `title` property instead, which now accepts any `ReactNode`.
+1 -2
View File
@@ -196,8 +196,7 @@ export type RouterProps = {
TaskPageComponent?: ComponentType<{}>;
};
groups?: Array<{
title?: string;
titleComponent?: React_2.ReactNode;
title?: React_2.ReactNode;
filter: (entity: Entity) => boolean;
}>;
defaultPreviewTemplate?: string;
+1 -2
View File
@@ -45,8 +45,7 @@ export type RouterProps = {
TaskPageComponent?: ComponentType<{}>;
};
groups?: Array<{
title?: string;
titleComponent?: React.ReactNode;
title?: React.ReactNode;
filter: (entity: Entity) => boolean;
}>;
defaultPreviewTemplate?: string;
@@ -46,8 +46,6 @@ export type ScaffolderPageProps = {
| undefined;
groups?: Array<{
title?: React.ReactNode;
/** @deprcated use title instead as it accepts a string and react component */
titleComponent?: React.ReactNode;
filter: (entity: Entity) => boolean;
}>;
};