chore(react-router-v6): revert paralell for tests, as my computer stared over 9000 node processes making my machine grind to a machine babbage would have disapointed with

This commit is contained in:
blam
2020-06-11 19:12:58 +02:00
parent 7ecfceac0f
commit da493b1fc9
5 changed files with 14 additions and 16 deletions
+1 -1
View File
@@ -11,7 +11,7 @@
"tsc": "tsc",
"clean": "backstage-cli clean && lerna run clean",
"diff": "lerna run diff --",
"test": "lerna run test --since origin/master --parallel -- --coverage",
"test": "lerna run test --since origin/master -- --coverage",
"test:all": "lerna run test -- --coverage",
"lint": "lerna run lint --since origin/master --",
"lint:all": "lerna run lint --",
+1 -3
View File
@@ -191,9 +191,7 @@ export class PrivateAppImpl implements BackstageApp {
<ApiProvider apis={apis}>
<AppContextProvider app={this}>
<AppThemeProvider>
<Router>
<Routes basename={pathname}>{children}</Routes>
</Router>
<Router>{children}</Router>
</AppThemeProvider>
</AppContextProvider>
</ApiProvider>
@@ -15,26 +15,25 @@
*/
import React from 'react';
import { render, fireEvent } from '@testing-library/react';
import { render, fireEvent, act } from '@testing-library/react';
import { wrapInTestApp } from '@backstage/test-utils';
import { Button } from './Button';
import { MemoryRouter, Route } from 'react-router';
import { act } from 'react-dom/test-utils';
import { Route } from 'react-router';
describe('<Button />', () => {
it('navigates using react-router', async () => {
const testString = 'This is test string';
const buttonLabel = 'Navigate!';
const { getByText } = render(
const { getByText, getByRole } = render(
wrapInTestApp(
<MemoryRouter>
<>
<Route path="/test" element={<p>{testString}</p>} />
<Button to="/test">{buttonLabel}</Button>
<Route path="/test">{testString}</Route>{' '}
</MemoryRouter>,
</>,
),
);
expect(() => getByText(testString)).toThrow();
await act(async () => fireEvent.click(getByText(buttonLabel)));
await act(async () => fireEvent.click(getByRole('button')));
expect(getByText(testString)).toBeInTheDocument();
});
});
@@ -18,7 +18,7 @@ import React from 'react';
import { render, fireEvent } from '@testing-library/react';
import { wrapInTestApp } from '@backstage/test-utils';
import { Link } from './Link';
import { MemoryRouter, Route } from 'react-router';
import { Route } from 'react-router';
import { act } from 'react-dom/test-utils';
describe('<Link />', () => {
@@ -27,14 +27,15 @@ describe('<Link />', () => {
const linkText = 'Navigate!';
const { getByText } = render(
wrapInTestApp(
<MemoryRouter>
<>
<Link to="/test">{linkText}</Link>
<Route path="/test">{testString}</Route>
</MemoryRouter>,
</>,
),
);
expect(() => getByText(testString)).toThrow();
await act(async () => fireEvent.click(getByText(linkText)));
expect(getByText(testString)).toBeInTheDocument();
});
});
@@ -18,7 +18,6 @@ import { Link, useParams } from 'react-router-dom';
import { useAsync } from 'react-use';
import {
makeStyles,
Button,
Grid,
List,
ListItem,
@@ -33,6 +32,7 @@ import {
Header,
Page,
Content,
Button,
ContentHeader,
HeaderLabel,
Progress,