Merge pull request #4004 from SDA-SE/feat/possible-jenkins-fix

Handle missing values in Jenkins API requests
This commit is contained in:
Oliver Sand
2021-01-11 12:19:37 +01:00
committed by GitHub
2 changed files with 11 additions and 2 deletions
+5
View File
@@ -0,0 +1,5 @@
---
'@backstage/plugin-jenkins': patch
---
Handle missing ObjectMetadataAction in Jenkins API
+6 -2
View File
@@ -63,7 +63,7 @@ export class JenkinsApi {
return lastBuild;
}
extractScmDetailsFromJob(jobDetails: any): any {
extractScmDetailsFromJob(jobDetails: any): any | undefined {
const scmInfo = jobDetails.actions
.filter(
(action: any) =>
@@ -79,6 +79,10 @@ export class JenkinsApi {
})
.pop();
if (!scmInfo) {
return undefined;
}
const author = jobDetails.actions
.filter(
(action: any) =>
@@ -141,7 +145,7 @@ export class JenkinsApi {
for (const jobDetails of folder.jobs) {
const jobScmInfo = this.extractScmDetailsFromJob(jobDetails);
if (jobDetails.jobs) {
if (jobDetails?.jobs) {
// skipping folders inside folders for now
} else {
for (const buildDetails of jobDetails.builds) {