chore(scaffolder): fixing issues with typescript and code review comment:

This commit is contained in:
blam
2020-06-29 18:05:56 +02:00
parent d5a0a5968e
commit d7dbc15b11
2 changed files with 2 additions and 3 deletions
@@ -20,7 +20,6 @@ import { TemplateEntityV1alpha1 } from '@backstage/catalog-model';
import { JsonValue } from '@backstage/config';
import { RequiredTemplateValues } from '../templater';
import { Repository, Remote, Signature, Cred } from 'nodegit';
import gitParse from 'git-url-parse';
export class GithubStorer implements Storer {
private client: Octokit;
@@ -34,7 +33,7 @@ export class GithubStorer implements Storer {
entity: TemplateEntityV1alpha1;
values: RequiredTemplateValues & Record<string, JsonValue>;
}) {
const [owner, name] = values.owner.split('/');
const [owner, name] = values.storePath.split('/');
const {
data: { clone_url: cloneUrl },
@@ -65,6 +65,6 @@ export class CookieCutter implements TemplaterBase {
dockerClient: options.dockerClient,
});
return path.resolve(resultDir, options.values.component_id);
return path.resolve(resultDir, options.values.component_id as string);
}
}