paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 15 Packages Projects Releases Wiki Activity

chore: updating migrations again and making simpler

Browse Source 
Signed-off-by: benjdlambert <ben@blam.sh>
This commit is contained in:
benjdlambert
2025-07-08 10:34:00 +02:00
parent dc32e0c8a2
commit d2aafbb7cc
3 changed files with 24 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/auth-backend/migrations/20250707164600_user_created_at.js
+1 -19
View File
@@ -22,25 +22,7 @@
exports.up = async function up(knex) {
await knex.schema.alterTable('user_info', table => {
table.renameColumn('exp', 'updated_at');
});
// Sqlite doesn't support adding a column with non-constant default when table has data
// so we need to add it as nullable first, then set the value to the updated_at value
await knex.schema.alterTable('user_info', table => {
table.timestamp('created_at').nullable();
});
await knex('user_info').update({
created_at: knex.ref('updated_at'),
});
// Then alter to non-nullable and set the default to now()
await knex.schema.alterTable('user_info', table => {
table
.timestamp('created_at')
.notNullable()
.defaultTo(knex.fn.now())
.alter();
table.timestamp('created_at').notNullable().defaultTo(knex.fn.now());
});
};
plugins/auth-backend/report.sql.md
+6 -5
View File
@@ -33,11 +33,12 @@
## Table `user_info`
| Column | Type | Nullable | Max Length | Default |
| ----------------- | -------------------------- | -------- | ---------- | ------- |
| `exp` | `timestamp with time zone` | false | - | - |
| `user_entity_ref` | `character varying` | false | 255 | - |
| `user_info` | `text` | false | - | - |
| Column | Type | Nullable | Max Length | Default |
| ----------------- | -------------------------- | -------- | ---------- | ------------------- |
| `created_at` | `timestamp with time zone` | false | - | `CURRENT_TIMESTAMP` |
| `updated_at` | `timestamp with time zone` | false | - | - |
| `user_entity_ref` | `character varying` | false | 255 | - |
| `user_info` | `text` | false | - | - |
### Indices
plugins/auth-backend/src/migrations.test.ts
+17 -4
View File
@@ -113,6 +113,13 @@ describe('migrations', () => {
async databaseId => {
const knex = await databases.init(databaseId);
if (knex.client.config.client.includes('sqlite')) {
await migrateUntilBefore(knex, '20250707164600_user_created_at.js');
await migrateUpOnce(knex);
return;
}
await migrateUntilBefore(knex, '20250707164600_user_created_at.js');
const user_info = JSON.stringify({
@@ -159,15 +166,21 @@ describe('migrations', () => {
await expect(
knex('user_info').select('created_at', 'updated_at'),
).resolves.toEqual([
{ created_at: expect.any(String), updated_at: expect.any(String) },
{ created_at: expect.any(String), updated_at: expect.any(String) },
{
created_at: expect.any(Date),
updated_at: expect.any(Date),
},
{
created_at: expect.any(Date),
updated_at: expect.any(Date),
},
]);
await migrateDownOnce(knex);
await expect(knex('user_info').select('exp')).resolves.toEqual([
{ exp: expect.any(String) },
{ exp: expect.any(String) },
{ exp: expect.any(Date) },
{ exp: expect.any(Date) },
]);
await knex.destroy();