review fixes

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
This commit is contained in:
Patrik Oldsberg
2026-02-17 13:19:22 +01:00
parent 40dfe4a00f
commit cfb4177cd8
5 changed files with 7 additions and 8 deletions
@@ -21,14 +21,13 @@ import { Page } from './Page';
type PageWithHeaderProps = ComponentProps<typeof Header> & {
themeId: string;
noHeader?: boolean;
};
export function PageWithHeader(props: PropsWithChildren<PageWithHeaderProps>) {
const { themeId, children, noHeader, ...restProps } = props;
const { themeId, children, ...restProps } = props;
return (
<Page themeId={themeId}>
{noHeader ? <div /> : <Header {...restProps} />}
<Header {...restProps} />
{children}
</Page>
);
@@ -1,5 +1,5 @@
/*
* Copyright 2025 The Backstage Authors
* Copyright 2026 The Backstage Authors
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -89,8 +89,8 @@ export const PageBlueprint = createExtensionBlueprint({
return (
<PageLayout
title={title}
icon={icon}
title={title ?? node.spec.plugin.title ?? node.spec.plugin.pluginId}
icon={icon ?? node.spec.plugin.icon}
noHeader={noHeader}
headerActions={headerActions}
>
@@ -1,5 +1,5 @@
/*
* Copyright 2024 The Backstage Authors
* Copyright 2026 The Backstage Authors
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -1,5 +1,5 @@
/*
* Copyright 2025 The Backstage Authors
* Copyright 2026 The Backstage Authors
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.