paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 39 Packages Projects Releases Wiki Activity

catalog-backend: fix syncSearchRows test to use real call path

Browse Source 
Replace the raw Knex onConflict().merge() insert in the
'overwrites original_value on conflict' test with a direct UPDATE to
corrupt the stored original_value, followed by a second syncSearchRows
call. This tests the actual application code path (ON CONFLICT DO UPDATE
inside syncSearchRows) rather than embedding the conflict logic in the
test itself.

Signed-off-by: Fredrik Adelöw <freben@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
Fredrik Adelöw
2026-05-11 20:05:47 +02:00
parent befdb6b31e
commit cdf38bd8db
1 changed files with 12 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/catalog-backend/src/database/operations/stitcher/syncSearchRows.test.ts
+12 -9
View File
@@ -245,21 +245,24 @@ describe.each(databases.eachSupportedId())('syncSearchRows, %p', databaseId => {
);
});
it('overwrites original_value on conflict via ON CONFLICT DO UPDATE', async () => {
it('restores original_value when re-syncing after it was corrupted', async () => {
await syncSearchRows(knex, 'e1', [row('a', 'x', 'X')]);
// Simulate a concurrent stitcher inserting the same (entity_id, key, value)
// with a different original_value casing. Unlike DO NOTHING, DO UPDATE
// requires an explicit conflict target — the column list is not optional.
await knex<DbSearchRow>('search')
.insert({ entity_id: 'e1', key: 'a', value: 'x', original_value: 'x' })
.onConflict(['entity_id', 'key', 'value'])
.merge(['original_value']);
// Corrupt the stored original_value (simulates stale or wrong data left
// by a previous stitcher run) without changing the key or value.
await knex('search')
.where({ entity_id: 'e1', key: 'a', value: 'x' })
.update({ original_value: 'corrupted' });
// Re-syncing the same desired rows should overwrite original_value back to
// 'X' via the ON CONFLICT DO UPDATE SET original_value = EXCLUDED.original_value
// clause inside syncSearchRows.
await syncSearchRows(knex, 'e1', [row('a', 'x', 'X')]);
const rows = await getSearchRows();
expect(rows).toHaveLength(1);
expect(rows[0]).toEqual(
expect.objectContaining({ key: 'a', value: 'x', original_value: 'x' }),
expect.objectContaining({ key: 'a', value: 'x', original_value: 'X' }),
);
});