chore: code-review comments

Signed-off-by: benjdlambert <ben@blam.sh>
This commit is contained in:
benjdlambert
2025-09-12 10:23:20 +02:00
parent a57185fd48
commit ca0aeea342
2 changed files with 4 additions and 4 deletions
@@ -280,7 +280,7 @@ describe('scaffolder router', () => {
expect(response.body.length).toBe(2);
});
it('should include actiosn from the remote actions registry', async () => {
it('should include actions from the remote actions registry', async () => {
const mockActionsRegistry = actionsRegistryServiceMock();
mockActionsRegistry.register({
name: 'my-demo-action',
@@ -133,7 +133,7 @@ import {
import { TaskFilters } from '@backstage/plugin-scaffolder-node';
import { ActionsService } from '@backstage/backend-plugin-api/alpha';
import { isObject } from 'lodash';
import { isPlainObject } from 'lodash';
/**
* RouterOptions
@@ -335,8 +335,8 @@ export async function createRouter(
credentials: await ctx.getInitiatorCredentials(),
});
if (isObject(output)) {
for (const [key, value] of Object.entries(output)) {
if (isPlainObject(output)) {
for (const [key, value] of Object.entries(output as JsonObject)) {
ctx.output(key as keyof typeof output, value);
}
}