address review comments

Signed-off-by: Fredrik Adelöw <freben@gmail.com>
This commit is contained in:
Fredrik Adelöw
2021-10-25 19:11:14 +02:00
parent 2a0ad49da0
commit c6c2942daa
4 changed files with 18 additions and 1 deletions
+5
View File
@@ -0,0 +1,5 @@
---
'@backstage/core-components': patch
---
Deprecated `DismissbleBannerClassKey` and fixed the typo to make `DismissableBannerClassKey`
+3
View File
@@ -294,6 +294,9 @@ export type DismissableBannerClassKey =
| 'info'
| 'error';
// @public @deprecated (undocumented)
export type DismissbleBannerClassKey = DismissableBannerClassKey;
// @public (undocumented)
export function DocsIcon(props: IconComponentProps): JSX.Element;
@@ -35,6 +35,12 @@ export type DismissableBannerClassKey =
| 'info'
| 'error';
/**
* @public
* @deprecated This type contained a typo, please use DismissableBannerClassKey instead
*/
export type DismissbleBannerClassKey = DismissableBannerClassKey;
const useStyles = makeStyles(
(theme: BackstageTheme) => ({
root: {
@@ -15,4 +15,7 @@
*/
export { DismissableBanner } from './DismissableBanner';
export type { DismissableBannerClassKey } from './DismissableBanner';
export type {
DismissableBannerClassKey,
DismissbleBannerClassKey,
} from './DismissableBanner';