Merge pull request #935 from spotify/freben/namespace

Make namespace schema stricter (according to k8s)

plugins/catalog-backend/src/ingestion/descriptors/DescriptorEnvelopeParser.ts

@@ -72,7 +72,7 @@ export class DescriptorEnvelopeParser {
       .test(
         'metadata.namespace',
         'The namespace is malformed',
-        value => value === undefined || validators.isValidEntityName(value),
+        value => value === undefined || validators.isValidNamespace(value),
       );
 
     const labelsSchema = yup

plugins/catalog-backend/src/validation/KubernetesValidatorFunctions.test.ts

@@ -83,6 +83,25 @@ describe('KubernetesValidatorFunctions', () => {
     expect(KubernetesValidatorFunctions.isValidObjectName(value)).toBe(matches);
   });
 
+  it.each([
+    [7, false],
+    [null, false],
+    ['', false],
+    ['a', true],
+    ['AZ09', false],
+    ['a'.repeat(63), true],
+    ['a'.repeat(64), false],
+    ['a/b', false],
+    ['a-b', true],
+    ['-a-b', false],
+    ['a-b-', false],
+    ['a--b', false],
+    ['a_b', false],
+    ['a.b', false],
+  ])('isValidNamespace', (value, matches) => {
+    expect(KubernetesValidatorFunctions.isValidNamespace(value)).toBe(matches);
+  });
+
   it.each([
     [7, false],
     [null, false],

plugins/catalog-backend/src/validation/KubernetesValidatorFunctions.ts

@@ -52,6 +52,10 @@ export class KubernetesValidatorFunctions {
     );
   }
 
+  static isValidNamespace(value: any): boolean {
+    return CommonValidatorFunctions.isValidDnsLabel(value);
+  }
+
   static isValidLabelKey(value: any): boolean {
     return CommonValidatorFunctions.isValidPrefixAndOrSuffix(
       value,

plugins/catalog-backend/src/validation/makeValidator.ts

@@ -22,6 +22,7 @@ const defaultValidators: Validators = {
   isValidApiVersion: KubernetesValidatorFunctions.isValidApiVersion,
   isValidKind: KubernetesValidatorFunctions.isValidKind,
   isValidEntityName: KubernetesValidatorFunctions.isValidObjectName,
+  isValidNamespace: KubernetesValidatorFunctions.isValidNamespace,
   normalizeEntityName: CommonValidatorFunctions.normalizeToLowercaseAlphanum,
   isValidLabelKey: KubernetesValidatorFunctions.isValidLabelKey,
   isValidLabelValue: KubernetesValidatorFunctions.isValidLabelValue,

plugins/catalog-backend/src/validation/types.ts

@@ -18,6 +18,7 @@ export type Validators = {
   isValidApiVersion(value: any): boolean;
   isValidKind(value: any): boolean;
   isValidEntityName(value: any): boolean;
+  isValidNamespace(value: any): boolean;
   normalizeEntityName(value: string): string;
   isValidLabelKey(value: any): boolean;
   isValidLabelValue(value: any): boolean;