Merge pull request #25755 from backstage/update-discoverability-owners

Update discoverability project area
2024-07-29 13:52:18 +02:00
parent fffb583132 edc977dd96
commit bd018b8ad8
20 changed files with 44 additions and 30 deletions
@@ -9,10 +9,10 @@ yarn.lock                                         @backstage/maintainers @backst
 */yarn.lock                                       @backstage/maintainers @backstage-service
 /.changeset/*.md
 /beps/0001-notifications-system                   @backstage/maintainers @backstage/notifications-maintainers
-/docs/assets/search                               @backstage/discoverability-maintainers
-/docs/features/search                             @backstage/discoverability-maintainers
+/docs/assets/search                               @backstage/search-maintainers
+/docs/features/search                             @backstage/search-maintainers
 /docs/features/techdocs                           @backstage/techdocs-maintainers
-/docs/plugins/integrating-search-into-plugins.md  @backstage/discoverability-maintainers
+/docs/plugins/integrating-search-into-plugins.md  @backstage/search-maintainers
 /packages/cli/src/commands/onboard                @backstage/sharks
 /packages/backend-openapi-utils                   @backstage/maintainers @backstage/reviewers @backstage/openapi-tooling-maintainers
 /packages/techdocs-cli                            @backstage/techdocs-maintainers
@@ -50,8 +50,8 @@ yarn.lock                                         @backstage/maintainers @backst
 /plugins/explore-react                            @backstage/maintainers @backstage/reviewers @backstage/sda-se-reviewers
 /plugins/fossa                                    @backstage/maintainers @backstage/reviewers @backstage/sda-se-reviewers
 /plugins/git-release-manager                      @backstage/maintainers @backstage/reviewers @erikengervall
-/plugins/home                                     @backstage/discoverability-maintainers
-/plugins/home-*                                   @backstage/discoverability-maintainers
+/plugins/home                                     @backstage/home-maintainers
+/plugins/home-*                                   @backstage/home-maintainers
 /plugins/kafka                                    @backstage/maintainers @backstage/reviewers @andrewthauer
 /plugins/kafka-backend                            @backstage/maintainers @backstage/reviewers @andrewthauer
 /plugins/kubernetes                               @backstage/kubernetes-maintainers
@@ -70,13 +70,11 @@ yarn.lock                                         @backstage/maintainers @backst
 /plugins/rollbar-backend                          @backstage/maintainers @backstage/reviewers @andrewthauer
 /plugins/scaffolder                               @backstage/maintainers @backstage/reviewers @backstage/scaffolder-maintainers
 /plugins/scaffolder-*                             @backstage/maintainers @backstage/reviewers @backstage/scaffolder-maintainers
-/plugins/search                                   @backstage/discoverability-maintainers
-/plugins/search-*                                 @backstage/discoverability-maintainers
+/plugins/search                                   @backstage/search-maintainers
+/plugins/search-*                                 @backstage/search-maintainers
 /plugins/signals                                  @backstage/maintainers @backstage/notifications-maintainers
 /plugins/signals-*                                @backstage/maintainers @backstage/notifications-maintainers
 /plugins/sonarqube                                @backstage/maintainers @backstage/reviewers @backstage/sda-se-reviewers
-/plugins/stack-overflow                           @backstage/discoverability-maintainers
-/plugins/stack-overflow-backend                   @backstage/discoverability-maintainers
 /plugins/techdocs                                 @backstage/techdocs-maintainers
 /plugins/techdocs-*                               @backstage/techdocs-maintainers
 /plugins/user-settings-backend                    @backstage/maintainers @backstage/reviewers @backstage/sda-se-reviewers
@@ -1,6 +1,6 @@
 area:techdocs:
  - '/(techdocs|tech-docs|tech docs)/i'
-area:discoverability:
+area:search:
  - '/search/i'
 area:events:
  - '/events/i'
@@ -4,7 +4,11 @@ area:catalog:
          - plugins/catalog/**/*
          - plugins/catalog-*/**/*
          - packages/catalog-*/**/*
-area:discoverability: # search + home
+area:home:
+  - changed-files:
+      - any-glob-to-any-file:
+          - plugins/home/**/*
+area:search:
  - changed-files:
      - any-glob-to-any-file:
          - plugins/search/**/*
@@ -32,11 +32,11 @@ Scope: The catalog plugin and catalog model
 | Patrik Oldsberg      | Spotify      | Cubic Belugas | [Rugvip](https://github.com/Rugvip)             | `Rugvip#0019`   |
 | Vincenzo Scamporlino | Spotify      | Cubic Belugas | [vinzscam](http://github.com/vinzscam)          | `vinzscam#6944` |

-### Discoverability
+### Home

-Team: @backstage/discoverability-maintainers
+Team: @backstage/home-maintainers

-Scope: Discoverability within Backstage, including the home page, information architecture, and search
+Scope: The Backstage home page and information architecture

 | Name                     | Organization | Team           | GitHub                                   | Discord           |
 | ------------------------ | ------------ | -------------- | ---------------------------------------- | ----------------- |
@@ -46,6 +46,18 @@ Scope: Discoverability within Backstage, including the home page, information ar
 | Raghunandan Balachandran | Spotify      | Infinite Buck$ | [soapraj](http://github.com/soapraj)     | raghunandanb#1114 |
 | Bailey Brooks            | Spotify      | Infinite Buck$ | [bailey](http://github.com/bailey)       | \_bailey4         |

+### Search
+
+Team: @backstage/search-maintainers
+
+Scope: The Backstage Search plugin
+
+| Name                     | Organization | Team           | GitHub                                        | Discord           |
+| ------------------------ | ------------ | -------------- | --------------------------------------------- | ----------------- |
+| Emma Indal               | Spotify      | Infinite Buck$ | [emmaindal](http://github.com/emmaindal)      | emmaindal#7503    |
+| Raghunandan Balachandran | Spotify      | Infinite Buck$ | [soapraj](http://github.com/soapraj)          | raghunandanb#1114 |
+| Alex Lorenzi             | Spotify      | ProTean        | [AlexLorenzi](https://github.com/AlexLorenzi) | alexlorenzi       |
+
 ### Helm Charts

 Team: @backstage/helm-chart-maintainers
@@ -9,4 +9,4 @@ metadata:
 spec:
  lifecycle: experimental
  type: backstage-web-library
-  owner: discoverability-maintainers
+  owner: home-maintainers
@@ -7,4 +7,4 @@ metadata:
 spec:
  lifecycle: experimental
  type: backstage-frontend-plugin
-  owner: discoverability-maintainers
+  owner: home-maintainers
@@ -24,7 +24,7 @@ describe('home', () => {

  // Temporarily ensure we are installing a working version of the react-grid-layout library
  // For more details, see: https://github.com/react-grid-layout/react-grid-layout/issues/1959
-  // TODO(@backstage/discoverability-maintainers): Delete this once the sub-dependency issue has been resolved.
+  // TODO(@backstage/home-maintainers): Delete this once the sub-dependency issue has been resolved.
  it('should pin react-grid-layout version to 1.3.4', async () => {
    expect(packageJson.dependencies['react-grid-layout']).toBe('1.3.4');
  });
@@ -7,4 +7,4 @@ metadata:
 spec:
  lifecycle: experimental
  type: backstage-backend-plugin-module
-  owner: discoverability-maintainers
+  owner: search-maintainers
@@ -7,4 +7,4 @@ metadata:
 spec:
  lifecycle: production
  type: backstage-backend-plugin-module
-  owner: discoverability-maintainers
+  owner: search-maintainers
@@ -313,7 +313,7 @@ export class ElasticSearchSearchEngine implements SearchEngine {
    });

    // Attempt cleanup upon failure.
-    // todo(@backstage/discoverability-maintainers): Consider introducing a more
+    // todo(@backstage/search-maintainers): Consider introducing a more
    // formal mechanism for handling such errors in BatchSearchEngineIndexer and
    // replacing this handler with it. See: #17291
    indexer.on('error', async e => {
@@ -7,4 +7,4 @@ metadata:
 spec:
  lifecycle: experimental
  type: backstage-backend-plugin-module
-  owner: discoverability-maintainers
+  owner: search-maintainers
@@ -7,4 +7,4 @@ metadata:
 spec:
  lifecycle: experimental
  type: backstage-backend-plugin-module
-  owner: discoverability-maintainers
+  owner: search-maintainers
@@ -104,7 +104,7 @@ export class PgSearchEngineIndexer extends BatchSearchEngineIndexer {
   * therefore an open connection to PG. This handler ensures we close the
   * transaction and associated connection.
   *
-   * todo(@backstage/discoverability-maintainers): Consider introducing a more
+   * todo(@backstage/search-maintainers): Consider introducing a more
   * formal mechanism for handling such errors in BatchSearchEngineIndexer and
   * replacing this method with it. See: #17291
   *
@@ -7,4 +7,4 @@ metadata:
 spec:
  lifecycle: experimental
  type: backstage-backend-plugin-module
-  owner: discoverability-maintainers
+  owner: search-maintainers
@@ -7,4 +7,4 @@ metadata:
 spec:
  lifecycle: experimental
  type: backstage-backend-plugin-module
-  owner: discoverability-maintainers
+  owner: search-maintainers
@@ -9,4 +9,4 @@ metadata:
 spec:
  lifecycle: production
  type: backstage-node-library
-  owner: discoverability-maintainers
+  owner: search-maintainers
@@ -7,4 +7,4 @@ metadata:
 spec:
  lifecycle: production
  type: backstage-backend-plugin
-  owner: discoverability-maintainers
+  owner: search-maintainers
@@ -9,4 +9,4 @@ metadata:
 spec:
  lifecycle: production
  type: backstage-common-library
-  owner: discoverability-maintainers
+  owner: search-maintainers
@@ -6,4 +6,4 @@ metadata:
 spec:
  lifecycle: production
  type: backstage-web-library
-  owner: discoverability-maintainers
+  owner: search-maintainers
@@ -7,4 +7,4 @@ metadata:
 spec:
  lifecycle: production
  type: backstage-frontend-plugin
-  owner: discoverability-maintainers
+  owner: search-maintainers