Merge pull request #23334 from IlyaSavich/fix-knip-fail

Send failed process status if knip fails

.changeset/cool-clouds-jump.md

@@ -0,0 +1,5 @@
+---
+'@backstage/repo-tools': minor
+---
+
+Fix knip-report command to send 1 exit status in case of fail

packages/repo-tools/src/commands/knip-reports/knip-extractor.ts

@@ -178,5 +178,7 @@ export async function runKnipReports({
       const fullDir = cliPaths.resolveTargetRoot(packageDir);
       cleanKnipConfig({ packageDir: fullDir });
     });
+
+    throw e;
   }
 }

packages/repo-tools/src/commands/knip-reports/knip-reports.ts

@@ -46,9 +46,14 @@ export const buildKnipReports = async (paths: string[] = [], opts: Options) => {
 
   if (selectedPackageDirs.length > 0) {
     console.log('# Generating package knip reports');
-    await runKnipReports({
-      packageDirs: selectedPackageDirs,
-      isLocalBuild: !isCiBuild,
-    });
+
+    try {
+      await runKnipReports({
+        packageDirs: selectedPackageDirs,
+        isLocalBuild: !isCiBuild,
+      });
+    } catch (e) {
+      process.exit(1);
+    }
   }
 };