Merge pull request #6030 from SDA-SE/feat/command-exists

Migrate from the `command-exists-promise` dependency to `command-exists`

plugins/scaffolder-backend/package.json

@@ -41,7 +41,7 @@
     "@types/express": "^4.17.6",
     "@types/git-url-parse": "^9.0.0",
     "azure-devops-node-api": "^10.1.1",
-    "command-exists-promise": "^2.0.2",
+    "command-exists": "^1.2.9",
     "compression": "^1.7.4",
     "cors": "^2.8.5",
     "cross-fetch": "^3.0.6",
@@ -66,6 +66,7 @@
   "devDependencies": {
     "@backstage/cli": "^0.7.0",
     "@backstage/test-utils": "^0.1.13",
+    "@types/command-exists": "^1.2.0",
     "@types/fs-extra": "^9.0.1",
     "@types/mock-fs": "^4.13.0",
     "@types/supertest": "^2.0.8",

plugins/scaffolder-backend/src/scaffolder/stages/templater/cookiecutter.test.ts

@@ -18,7 +18,7 @@ const runCommand = jest.fn();
 const commandExists = jest.fn();
 
 jest.mock('./helpers', () => ({ runCommand }));
-jest.mock('command-exists-promise', () => commandExists);
+jest.mock('command-exists', () => commandExists);
 jest.mock('fs-extra');
 
 import { ContainerRunner } from '@backstage/backend-common';

plugins/scaffolder-backend/src/scaffolder/stages/templater/cookiecutter.ts

@@ -16,13 +16,12 @@
 
 import { ContainerRunner } from '@backstage/backend-common';
 import { JsonValue } from '@backstage/config';
+import commandExists from 'command-exists';
 import fs from 'fs-extra';
 import path from 'path';
 import { runCommand } from './helpers';
 import { TemplaterBase, TemplaterRunOptions } from './types';
 
-const commandExists = require('command-exists-promise');
-
 export class CookieCutter implements TemplaterBase {
   private readonly containerRunner: ContainerRunner;