paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 22 Packages Projects Releases Wiki Activity

Merge pull request #6030 from SDA-SE/feat/command-exists

Browse Source 
Migrate from the `command-exists-promise` dependency to `command-exists`
This commit is contained in:
Fredrik Adelöw
2021-06-15 15:41:12 +02:00
committed by GitHub
parent dc728f5874 ca70bd37d5
commit b811b1e1b1
5 changed files with 14 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.changeset/thick-donkeys-carry.md
+5
View File
@@ -0,0 +1,5 @@
---
'@backstage/plugin-scaffolder-backend': patch
---
Migrate from the `command-exists-promise` dependency to `command-exists`.
plugins/scaffolder-backend/package.json
+2 -1
View File
@@ -41,7 +41,7 @@
"@types/express": "^4.17.6",
"@types/git-url-parse": "^9.0.0",
"azure-devops-node-api": "^10.1.1",
"command-exists-promise": "^2.0.2",
"command-exists": "^1.2.9",
"compression": "^1.7.4",
"cors": "^2.8.5",
"cross-fetch": "^3.0.6",
@@ -66,6 +66,7 @@
"devDependencies": {
"@backstage/cli": "^0.7.0",
"@backstage/test-utils": "^0.1.13",
"@types/command-exists": "^1.2.0",
"@types/fs-extra": "^9.0.1",
"@types/mock-fs": "^4.13.0",
"@types/supertest": "^2.0.8",
plugins/scaffolder-backend/src/scaffolder/stages/templater/cookiecutter.test.ts
+1 -1
View File
@@ -18,7 +18,7 @@ const runCommand = jest.fn();
const commandExists = jest.fn();
jest.mock('./helpers', () => ({ runCommand }));
jest.mock('command-exists-promise', () => commandExists);
jest.mock('command-exists', () => commandExists);
jest.mock('fs-extra');
import { ContainerRunner } from '@backstage/backend-common';
plugins/scaffolder-backend/src/scaffolder/stages/templater/cookiecutter.ts
+1 -2
View File
@@ -16,13 +16,12 @@
import { ContainerRunner } from '@backstage/backend-common';
import { JsonValue } from '@backstage/config';
import commandExists from 'command-exists';
import fs from 'fs-extra';
import path from 'path';
import { runCommand } from './helpers';
import { TemplaterBase, TemplaterRunOptions } from './types';
const commandExists = require('command-exists-promise');
export class CookieCutter implements TemplaterBase {
private readonly containerRunner: ContainerRunner;
yarn.lock
+5 -5
View File
@@ -5506,6 +5506,11 @@
dependencies:
"@types/color-convert" "*"
"@types/command-exists@^1.2.0":
version "1.2.0"
resolved "https://registry.npmjs.org/@types/command-exists/-/command-exists-1.2.0.tgz#d97e0ed10097090e4ab0367ed425b0312fad86f3"
integrity sha512-ugsxEJfsCuqMLSuCD4PIJkp5Uk2z6TCMRCgYVuhRo5cYQY3+1xXTQkSlPtkpGHuvWMjS2KTeVQXxkXRACMbM6A==
"@types/compression@^1.7.0":
version "1.7.0"
resolved "https://registry.npmjs.org/@types/compression/-/compression-1.7.0.tgz#8dc2a56604873cf0dd4e746d9ae4d31ae77b2390"
@@ -9794,11 +9799,6 @@ comma-separated-tokens@^1.0.0:
resolved "https://registry.npmjs.org/comma-separated-tokens/-/comma-separated-tokens-1.0.8.tgz#632b80b6117867a158f1080ad498b2fbe7e3f5ea"
integrity sha512-GHuDRO12Sypu2cV70d1dkA2EUmXHgntrzbpvOB+Qy+49ypNfGgFQIC2fhhXbnyrJRynDCAARsT7Ou0M6hirpfw==
command-exists-promise@^2.0.2:
version "2.0.2"
resolved "https://registry.npmjs.org/command-exists-promise/-/command-exists-promise-2.0.2.tgz#7beecc4b218299f3c61fa69a4047aa0b36a64a99"
integrity sha512-T6PB6vdFrwnHXg/I0kivM3DqaCGZLjjYSOe0a5WgFKcz1sOnmOeIjnhQPXVXX3QjVbLyTJ85lJkX6lUpukTzaA==
command-exists@^1.2.9:
version "1.2.9"
resolved "https://registry.npmjs.org/command-exists/-/command-exists-1.2.9.tgz#c50725af3808c8ab0260fd60b01fbfa25b954f69"