fix props

Signed-off-by: mufaddal motiwala <mufaddalmm.52@gmail.com>
This commit is contained in:
mufaddal motiwala
2022-09-09 11:03:45 +05:30
parent d9b7dd9032
commit b55966c460
2 changed files with 13 additions and 9 deletions
@@ -14,21 +14,25 @@
* limitations under the License.
*/
import { Box } from '@material-ui/core';
import React from 'react';
import React, { useEffect, useRef } from 'react';
import { DismissableBanner } from '@backstage/core-components';
import { TaskStream } from '../hooks/useEventStream';
type TaskPageLinksProps = {
taskStream: TaskStream;
type TaskErrorsProps = {
error?: Error;
};
export const TaskErrors = ({ taskStream }: TaskPageLinksProps) => {
return taskStream.error ? (
export const TaskErrors = ({ error }: TaskErrorsProps) => {
const id = useRef('');
useEffect(() => {
id.current = String(Math.random());
}, [error]);
return error ? (
<Box>
<DismissableBanner
id={String(Math.random())}
id={id.current}
variant="warning"
message={taskStream.error.message}
message={error.message}
/>
</Box>
) : null;
@@ -357,7 +357,7 @@ export const TaskPage = ({ loadingText }: TaskPageProps) => {
{!currentStepId && <Progress />}
<div style={{ height: '80vh' }}>
<TaskErrors taskStream={taskStream} />
<TaskErrors error={taskStream.error} />
<LogViewer text={logAsString} />
</div>
</Grid>