Move known plugin package constants from cli-common to cli-internal

The known plugin package ID mappings don't need to be part of the
public API surface. Move them to @internal/cli and update consumers.

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Made-with: Cursor

.changeset/clever-insects-tan.md

@@ -1,6 +1,5 @@
 ---
 '@backstage/cli-module-maintenance': patch
-'@backstage/cli-common': patch
 ---
 
-Exposes `knownBackendPluginPackageNameByPluginId` and `knownFrontendPluginPackageNameByPluginId` from `@backstage/cli-common` for auto-filling plugin package names.
+Added auto-fill of `backstage.pluginPackage` metadata for known plugins during `repo fix`.

packages/cli-common/report.api.md

@@ -28,12 +28,6 @@ export function findPaths(searchDir: string): Paths;
 // @public
 export function isChildPath(base: string, path: string): boolean;
 
-// @public
-export const knownBackendPluginPackageNameByPluginId: Record<string, string>;
-
-// @public
-export const knownFrontendPluginPackageNameByPluginId: Record<string, string>;
-
 // @public
 export type OwnPaths = {
   dir: string;

packages/cli-common/src/index.ts

@@ -33,7 +33,3 @@ export {
   type RunOnOutput,
 } from './run';
 export { ExitCodeError } from './errors';
-export {
-  knownBackendPluginPackageNameByPluginId,
-  knownFrontendPluginPackageNameByPluginId,
-} from './knownPluginPackages';

packages/cli-internal/src/index.ts

@@ -31,3 +31,7 @@ export {
   resetSecretStore,
   type SecretStore,
 } from './secretStore';
+export {
+  knownBackendPluginPackageNameByPluginId,
+  knownFrontendPluginPackageNameByPluginId,
+} from './knownPluginPackages';

packages/cli-internal/src/knownPluginPackages.ts

@@ -44,8 +44,6 @@ const knownFrontendPluginIds = [
 
 /**
  * Maps known plugin IDs to their corresponding backend package names.
- *
- * @public
  */
 export const knownBackendPluginPackageNameByPluginId: Record<string, string> =
   Object.fromEntries(
@@ -57,8 +55,6 @@ export const knownBackendPluginPackageNameByPluginId: Record<string, string> =
 
 /**
  * Maps known plugin IDs to their corresponding frontend package names.
- *
- * @public
  */
 export const knownFrontendPluginPackageNameByPluginId: Record<string, string> =
   Object.fromEntries(

packages/cli-module-maintenance/package.json

@@ -19,6 +19,7 @@
   "license": "Apache-2.0",
   "main": "src/index.ts",
   "types": "src/index.ts",
+  "bin": "bin/backstage-cli-module-maintenance",
   "files": [
     "dist",
     "bin"
@@ -42,6 +43,5 @@
   "devDependencies": {
     "@backstage/cli": "workspace:^",
     "@types/fs-extra": "^11.0.0"
-  },
-  "bin": "bin/backstage-cli-module-maintenance"
+  }
 }

packages/cli-module-maintenance/src/commands/repo/fix.ts

@@ -29,11 +29,11 @@ import {
   relative as relativePath,
   extname,
 } from 'node:path';
+import { targetPaths } from '@backstage/cli-common';
 import {
-  targetPaths,
   knownBackendPluginPackageNameByPluginId,
   knownFrontendPluginPackageNameByPluginId,
-} from '@backstage/cli-common';
+} from '@internal/cli';
 
 const SCRIPT_EXTS = ['.js', '.jsx', '.ts', '.tsx', '.json'];
 

packages/cli-module-new/src/lib/preparation/collectPortableTemplateInput.ts

@@ -16,11 +16,11 @@
 
 import inquirer, { DistinctQuestion } from 'inquirer';
 import { getCodeownersFilePath, parseOwnerIds } from '../codeowners';
+import { targetPaths } from '@backstage/cli-common';
 import {
-  targetPaths,
   knownBackendPluginPackageNameByPluginId,
   knownFrontendPluginPackageNameByPluginId,
-} from '@backstage/cli-common';
+} from '@internal/cli';
 
 import {
   PortableTemplateConfig,