Merge pull request #6445 from angeliski/fix-windows-build

fix windows paths

.changeset/polite-spies-judge.md

@@ -0,0 +1,5 @@
+---
+'@backstage/plugin-scaffolder-backend-module-rails': patch
+---
+
+updated paths to consider differences between platform (windows corrected)

plugins/scaffolder-backend-module-rails/src/actions/fetch/rails/railsArgumentResolver.ts

@@ -56,6 +56,7 @@ export type RailsRunOptions = {
 export const railsArgumentResolver = (
   projectRoot: string,
   options: RailsRunOptions,
+  executionOnContainer = false,
 ): string[] => {
   const argumentsToRun: string[] = [];
 
@@ -103,7 +104,7 @@ export const railsArgumentResolver = (
     argumentsToRun.push(
       options.template.replace(
         `.${separatorPath}`,
-        `${projectRoot}${separatorPath}`,
+        `${projectRoot}${executionOnContainer ? '/' : separatorPath}`,
       ),
     );
   }

plugins/scaffolder-backend-module-rails/src/actions/fetch/rails/railsNewRunner.test.ts

@@ -137,7 +137,7 @@ describe('Rails Templater', () => {
         owner: 'angeliski',
         storePath: 'https://github.com/angeliski/rails-project',
         name: 'rails-project',
-        railsArguments: { template: './something.rb' },
+        railsArguments: { template: `.${path.sep}something.rb` },
         imageName: 'foo/rails-custom-image',
       };
 
@@ -210,7 +210,7 @@ describe('Rails Templater', () => {
         owner: 'angeliski',
         storePath: 'https://github.com/angeliski/rails-project',
         name: 'rails-project',
-        railsArguments: { template: './something.rb' },
+        railsArguments: { template: `.${path.sep}something.rb` },
         imageName: 'foo/rails-custom-image',
       };
 

plugins/scaffolder-backend-module-rails/src/actions/fetch/rails/railsNewRunner.ts

@@ -68,7 +68,7 @@ export class RailsNewRunner {
         command: baseCommand,
         args: [
           ...baseArguments,
-          `${intermediateDir}/${name}`,
+          `${intermediateDir}${path.sep}${name}`,
           ...arrayExtraArguments,
         ],
         logStream,
@@ -77,6 +77,7 @@ export class RailsNewRunner {
       const arrayExtraArguments = railsArgumentResolver(
         '/input',
         railsArguments as RailsRunOptions,
+        true,
       );
       await this.containerRunner.runContainer({
         imageName: imageName as string,