Merge pull request #26220 from backstage/nbs10/foward-ref-in-service-factory-options-type

[NBS 1.0] Remove unnecessary todo
This commit is contained in:
Camila Belo
2024-08-26 18:19:09 +02:00
committed by GitHub
2 changed files with 2 additions and 2 deletions
+1 -1
View File
@@ -514,7 +514,7 @@ export interface RootLoggerService extends LoggerService {}
// @public (undocumented)
export interface RootServiceFactoryOptions<
TService, // TODO(Rugvip): Can we forward the entire service ref type here instead of forwarding each type arg once the callback form is gone?
TService,
TInstances extends 'singleton' | 'multiton',
TImpl extends TService,
TDeps extends {
@@ -165,7 +165,7 @@ type ServiceRefsToInstances<
/** @public */
export interface RootServiceFactoryOptions<
TService, // TODO(Rugvip): Can we forward the entire service ref type here instead of forwarding each type arg once the callback form is gone?
TService,
TInstances extends 'singleton' | 'multiton',
TImpl extends TService,
TDeps extends { [name in string]: ServiceRef<unknown> },