feature(catalog export): fix review comments and build

Signed-off-by: the-serious-programmer <19777147+the-serious-programmer@users.noreply.github.com>
This commit is contained in:
the-serious-programmer
2026-04-19 10:21:42 +02:00
parent 7f48d8a5ec
commit ae7e0fdd68
3 changed files with 14 additions and 11 deletions
+4 -4
View File
@@ -193,8 +193,8 @@ export const catalogTranslationRef: TranslationRef<
readonly 'aboutCard.targetsField.label': 'Targets';
readonly 'searchResultItem.type': 'Type';
readonly 'searchResultItem.kind': 'Kind';
readonly 'searchResultItem.lifecycle': 'Lifecycle';
readonly 'searchResultItem.owner': 'Owner';
readonly 'searchResultItem.lifecycle': 'Lifecycle';
readonly 'catalogTable.allFilters': 'All';
readonly 'catalogTable.warningPanelTitle': 'Could not fetch catalog entities.';
readonly 'catalogTable.viewActionTitle': 'View';
@@ -214,16 +214,16 @@ export const catalogTranslationRef: TranslationRef<
readonly 'entityContextMenu.unregisterMenuTitle': 'Unregister entity';
readonly 'entityContextMenu.moreButtonAriaLabel': 'more';
readonly 'entityLabelsCard.title': 'Labels';
readonly 'entityLabelsCard.readMoreButtonTitle': 'Read more';
readonly 'entityLabelsCard.columnKeyLabel': 'Label';
readonly 'entityLabelsCard.columnValueLabel': 'Value';
readonly 'entityLabelsCard.emptyDescription': 'No labels defined for this entity. You can add labels to your entity YAML as shown in the highlighted example below:';
readonly 'entityLabelsCard.readMoreButtonTitle': 'Read more';
readonly 'entityLabels.warningPanelTitle': 'Entity not found';
readonly 'entityLabels.ownerLabel': 'Owner';
readonly 'entityLabels.warningPanelTitle': 'Entity not found';
readonly 'entityLabels.lifecycleLabel': 'Lifecycle';
readonly 'entityLinksCard.title': 'Links';
readonly 'entityLinksCard.emptyDescription': 'No links defined for this entity. You can add links to your entity YAML as shown in the highlighted example below:';
readonly 'entityLinksCard.readMoreButtonTitle': 'Read more';
readonly 'entityLinksCard.emptyDescription': 'No links defined for this entity. You can add links to your entity YAML as shown in the highlighted example below:';
readonly 'entityNotFound.title': 'Entity was not found';
readonly 'entityNotFound.description': 'Want to help us build this? Check out our Getting Started documentation.';
readonly 'entityNotFound.docButtonTitle': 'DOCS';
+4 -4
View File
@@ -293,8 +293,8 @@ export const catalogTranslationRef: TranslationRef<
readonly 'aboutCard.targetsField.label': 'Targets';
readonly 'searchResultItem.type': 'Type';
readonly 'searchResultItem.kind': 'Kind';
readonly 'searchResultItem.lifecycle': 'Lifecycle';
readonly 'searchResultItem.owner': 'Owner';
readonly 'searchResultItem.lifecycle': 'Lifecycle';
readonly 'catalogTable.allFilters': 'All';
readonly 'catalogTable.warningPanelTitle': 'Could not fetch catalog entities.';
readonly 'catalogTable.viewActionTitle': 'View';
@@ -314,16 +314,16 @@ export const catalogTranslationRef: TranslationRef<
readonly 'entityContextMenu.unregisterMenuTitle': 'Unregister entity';
readonly 'entityContextMenu.moreButtonAriaLabel': 'more';
readonly 'entityLabelsCard.title': 'Labels';
readonly 'entityLabelsCard.readMoreButtonTitle': 'Read more';
readonly 'entityLabelsCard.columnKeyLabel': 'Label';
readonly 'entityLabelsCard.columnValueLabel': 'Value';
readonly 'entityLabelsCard.emptyDescription': 'No labels defined for this entity. You can add labels to your entity YAML as shown in the highlighted example below:';
readonly 'entityLabelsCard.readMoreButtonTitle': 'Read more';
readonly 'entityLabels.warningPanelTitle': 'Entity not found';
readonly 'entityLabels.ownerLabel': 'Owner';
readonly 'entityLabels.warningPanelTitle': 'Entity not found';
readonly 'entityLabels.lifecycleLabel': 'Lifecycle';
readonly 'entityLinksCard.title': 'Links';
readonly 'entityLinksCard.emptyDescription': 'No links defined for this entity. You can add links to your entity YAML as shown in the highlighted example below:';
readonly 'entityLinksCard.readMoreButtonTitle': 'Read more';
readonly 'entityLinksCard.emptyDescription': 'No links defined for this entity. You can add links to your entity YAML as shown in the highlighted example below:';
readonly 'entityNotFound.title': 'Entity was not found';
readonly 'entityNotFound.description': 'Want to help us build this? Check out our Getting Started documentation.';
readonly 'entityNotFound.docButtonTitle': 'DOCS';
@@ -23,7 +23,10 @@ import {
CatalogExportSettingsColumn,
} from './serializeEntities';
import { CatalogExportType } from '../CatalogExportButton';
import type { StreamEntitiesRequest } from '@backstage/catalog-client';
import type {
CatalogApi,
StreamEntitiesRequest,
} from '@backstage/catalog-client';
import { filtersToStreamRequest } from './filtersToStreamRequest';
/**
@@ -62,7 +65,7 @@ async function* streamEntitiesCsvGenerator({
columns,
streamRequest,
}: {
catalogApi: any;
catalogApi: CatalogApi;
columns: CatalogExportSettingsColumn[];
streamRequest?: StreamEntitiesRequest;
}): AsyncGenerator<string, void, unknown> {
@@ -86,7 +89,7 @@ async function* streamEntitiesJsonGenerator({
columns,
streamRequest,
}: {
catalogApi: any;
catalogApi: CatalogApi;
columns: CatalogExportSettingsColumn[];
streamRequest?: StreamEntitiesRequest;
}): AsyncGenerator<string, void, unknown> {