paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 43 Packages Projects Releases Wiki Activity

cli: revert default cjs build extension to .cjs.js

Browse Source 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
This commit is contained in:
Patrik Oldsberg
2024-12-26 18:49:16 +01:00
parent ecea207457
commit ac27fdb5b5
2 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/cli/src/lib/builder/config.ts
+2 -1
View File
@@ -49,6 +49,7 @@ const MODULE_EXTS = ['.mjs', '.mts'];
const COMMONJS_EXTS = ['.cjs', '.cts'];
const MOD_EXT = '.mjs';
const CJS_EXT = '.cjs';
const CJS_JS_EXT = '.cjs.js';
function isFileImport(source: string) {
if (source.startsWith('.')) {
@@ -169,7 +170,7 @@ export async function makeRollupConfigs(
// file extensions. That way we are left with a combination of .cjs and .mjs
// files where the module format in the file matches the file extension.
if (options.outputs.has(Output.cjs)) {
const defaultExt = targetPkg.type === 'module' ? MOD_EXT : CJS_EXT;
const defaultExt = targetPkg.type === 'module' ? MOD_EXT : CJS_JS_EXT;
const outputOpts: OutputOptions = {
dir: distDir,
entryFileNames(chunkInfo) {
packages/cli/src/tests/transforms/transforms.test.ts
+4 -4
View File
@@ -167,7 +167,7 @@ describe('package build transforms', () => {
outputs: new Set([Output.cjs]),
workspacePackages: [],
});
const values = await import(resolvePath(pkgPath, 'dist/index.cjs')).then(
const values = await import(resolvePath(pkgPath, 'dist/index.cjs.js')).then(
m => m.values,
);
expect(values).toEqual({
@@ -180,7 +180,7 @@ describe('package build transforms', () => {
dyn: exportValues.all,
});
expect(loadFixture('pkg-commonjs/dist/print.cjs')).toEqual({
expect(loadFixture('pkg-commonjs/dist/print.cjs.js')).toEqual({
depCommonJs: expectedExports.commonJs,
depDefault: expectedExports.commonJs,
dynCommonJs: expectedExports.commonJs,
@@ -199,7 +199,7 @@ describe('package build transforms', () => {
outputs: new Set([Output.cjs]),
workspacePackages: [],
});
const values = await import(resolvePath(pkgPath, 'dist/index.cjs')).then(
const values = await import(resolvePath(pkgPath, 'dist/index.cjs.js')).then(
m => m.values,
);
expect(values).toEqual({
@@ -212,7 +212,7 @@ describe('package build transforms', () => {
dyn: exportValues.all,
});
expect(loadFixture('pkg-default/dist/print.cjs')).toEqual({
expect(loadFixture('pkg-default/dist/print.cjs.js')).toEqual({
depCommonJs: expectedExports.commonJs,
depDefault: expectedExports.commonJs,
dynCommonJs: expectedExports.commonJs,