paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 32 Packages Projects Releases Wiki Activity

Fix spelling errors

Browse Source
This commit is contained in:
Taras Mankovski
2020-10-03 05:45:31 -04:00
parent 0ff2b6788f
commit a86444265c
5 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.changeset/2284.md
+1 -1
View File
@@ -4,7 +4,7 @@
'@backstage/plugin-auth-backend': minor
---
Add saml login to backstage
Add SAML login to backstage
![](https://user-images.githubusercontent.com/872486/92251660-bb9e3400-eeff-11ea-86fe-1f2a0262cd31.png)
.changeset/2535.md
+1 -1
View File
@@ -7,7 +7,7 @@ Fix banner position and color
This PR closes: #2245
The "fixed" props added to control the position of the banner. When it is set to true the banner will be shown in bottom of tha page and the width will be based on the content of the message.
The "fixed" props added to control the position of the banner. When it is set to true the banner will be shown in bottom of that page and the width will be based on the content of the message.
![](https://user-images.githubusercontent.com/15106494/93765685-999df480-fc15-11ea-8fa5-11cac5836cf1.png)
.changeset/2600.md
+2 -2
View File
@@ -14,6 +14,6 @@ Went with an interface similar to the frontend DiscoveryApi, since it's dead sim
Also ended up with two different methods, one for internal endpoint discovery and one for external. The two use-cases are explained a bit more in the docs, but basically it's service-to-service vs callback URLs.
This did get me thinking about uniqueness and that we're heading towards a global namespace for backend plugin IDs. That's probably fine tbh, but if we're happy with that we should leverage it a bit more to simplify the backend setup. For example we'd have each plugin provide its own ID and not manually mount on paths in the backend.
This did get me thinking about uniqueness and that we're heading towards a global namespace for backend plugin IDs. That's probably fine, but if we're happy with that we should leverage it a bit more to simplify the backend setup. For example we'd have each plugin provide its own ID and not manually mount on paths in the backend.
Draft until we're happy with the implementation, then I can add more docs and changelog entry. Also didn't go on a thorough hunt for places where discovery can be used, but tbh I don't think there are many since it's been pretty awkward to do service-to-service communication.
Draft until we're happy with the implementation, then I can add more docs and changelog entry. Also didn't go on a thorough hunt for places where discovery can be used, but I don't think there are many since it's been pretty awkward to do service-to-service communication.
.changeset/2603.md
+1 -1
View File
@@ -3,6 +3,6 @@
'@backstage/create-app': minor
---
Make csp configurable to unbreak app-backend served app not being able to fetch
Make CSP configurable to fix app-backend served app not being able to fetch
See discussion [here on discord](https://discordapp.com/channels/687207715902193673/687235481154617364/758721460163575850)
.changeset/2674.md
+1 -1
View File
@@ -9,4 +9,4 @@ Relates to #1598.
This creates databases for plugins before handing off control to plugins.
The list of plugins currently need to be hardcoded depending on the installed plugins. A later PR will properly refactor the code to provide a factory pattern where plugins specify what they need, and knex instances will be provided based on the input.
The list of plugins currently need to be hard-coded depending on the installed plugins. A later PR will properly refactor the code to provide a factory pattern where plugins specify what they need, and Knex instances will be provided based on the input.