Merge pull request #727 from spotify/freben/winston

Simplify logger creation in tests

packages/backend-common/src/logging/rootLogger.test.ts

@@ -14,18 +14,13 @@
  * limitations under the License.
  */
 
-import { PassThrough } from 'stream';
 import winston from 'winston';
 import { getRootLogger, setRootLogger } from './rootLogger';
 
 describe('rootLogger', () => {
   it('can replace the default logger', () => {
-    const logger = winston.createLogger({
-      transports: [
-        new winston.transports.Stream({ stream: new PassThrough() }),
-      ],
-    });
-    jest.spyOn(logger, 'info');
+    const logger = winston.createLogger();
+    jest.spyOn(logger, 'info').mockReturnValue(logger);
 
     setRootLogger(logger);
     getRootLogger().info('testing');

packages/backend-common/src/middleware/requestLoggingHandler.test.ts

@@ -15,19 +15,14 @@
  */
 
 import express from 'express';
-import { PassThrough } from 'stream';
 import request from 'supertest';
 import winston from 'winston';
 import { requestLoggingHandler } from './requestLoggingHandler';
 
 describe('requestLoggingHandler', () => {
   it('emits logs for each request', async () => {
-    const logger = winston.createLogger({
-      transports: [
-        new winston.transports.Stream({ stream: new PassThrough() }),
-      ],
-    });
-    jest.spyOn(logger, 'info');
+    const logger = winston.createLogger();
+    jest.spyOn(logger, 'info').mockReturnValue(logger);
 
     const app = express();
     app.use(requestLoggingHandler(logger));