core-plugin-api: remove the need to declare translation messages as const

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>

packages/core-app-api/src/apis/implementations/TranslationApi/I18nextTranslationApi.test.ts

@@ -360,7 +360,9 @@ describe('I18nextTranslationApi', () => {
     await new Promise<void>(resolve => {
       const subscription = translationApi.translation$(plainRef).subscribe({
         next(snapshot) {
-          const translation = snapshot.ready ? snapshot.t('foo') : null;
+          const translation = snapshot.ready
+            ? (snapshot.t('foo') as string)
+            : null;
           translations.push(translation);
 
           if (translation === 'foo') {

packages/core-plugin-api/alpha-api-report.md

@@ -41,7 +41,7 @@ export function createTranslationMessages<
 // @alpha (undocumented)
 export function createTranslationRef<
   TId extends string,
-  TMessages extends {
+  const TMessages extends {
     [key in string]: string;
   },
   TTranslations extends {

packages/core-plugin-api/src/translation/TranslationMessages.test.ts

@@ -23,7 +23,7 @@ const ref = createTranslationRef({
     one: 'one',
     two: 'two',
     three: 'three',
-  } as const,
+  },
 });
 
 describe('createTranslationMessages', () => {

packages/core-plugin-api/src/translation/TranslationRef.ts

@@ -108,7 +108,7 @@ class TranslationRefImpl<
 /** @alpha */
 export function createTranslationRef<
   TId extends string,
-  TMessages extends { [key in string]: string },
+  const TMessages extends { [key in string]: string },
   TTranslations extends {
     [language in string]: () => Promise<{
       default: { [key in keyof TMessages]: string | null };

plugins/adr/src/translations.ts

@@ -22,5 +22,5 @@ export const adrTranslationRef = createTranslationRef({
     content_header_title: 'Architecture Decision Records',
     failed_to_fetch: 'Failed to fetch ADRs',
     no_adrs: 'No ADRs found',
-  } as const,
+  },
 });

plugins/user-settings/src/translation.ts

@@ -30,5 +30,5 @@ export const userSettingsTranslationRef = createTranslationRef({
     select_theme: 'Select {{theme}}',
     select_theme_auto: 'Select Auto Theme',
     select_lng: 'Select language {{language}}',
-  } as const,
+  },
 });