Merge pull request #23877 from brianphillips/github-pr-board-null-statusCheckRollup

Handle "null" statusCheckRollup values on commits

.changeset/twelve-comics-double.md

@@ -0,0 +1,5 @@
+---
+'@backstage/plugin-github-pull-requests-board': patch
+---
+
+Handle null values returned from GitHub for the statusCheckRollup value on the commit object

plugins/github-pull-requests-board/src/components/Card/CardHeader.tsx

@@ -92,7 +92,7 @@ const CardHeader: FunctionComponent<Props> = (props: Props) => {
         <Box display="flex" alignItems="center" flexWrap="wrap" paddingTop={1}>
           <Typography variant="body2" component="p">
             Commit Status:{' '}
-            <strong>{status.commit.statusCheckRollup.state}</strong>
+            <strong>{status.commit.statusCheckRollup?.state || 'N/A'}</strong>
           </Typography>
         </Box>
       )}

plugins/github-pull-requests-board/src/components/EntityTeamPullRequestsCard/EntityTeamPullRequestsCard.test.tsx

@@ -96,9 +96,7 @@ jest.mock('../../hooks/usePullRequestsByTeam', () => {
           isArchived: false,
           status: {
             commit: {
-              statusCheckRollup: {
-                state: 'FAILURE',
-              },
+              statusCheckRollup: null,
             },
           },
         }),

plugins/github-pull-requests-board/src/components/EntityTeamPullRequestsContent/EntityTeamPullRequestsContent.test.tsx

@@ -96,9 +96,7 @@ jest.mock('../../hooks/usePullRequestsByTeam', () => {
           isArchived: false,
           status: {
             commit: {
-              statusCheckRollup: {
-                state: 'FAILURE',
-              },
+              statusCheckRollup: null,
             },
           },
         }),

plugins/github-pull-requests-board/src/utils/types.tsx

@@ -85,7 +85,7 @@ export type Status = {
   commit: {
     statusCheckRollup: {
       state: string;
-    };
+    } | null;
   };
 };