config-loader: pass in env as an option

packages/backend-common/src/config.ts

@@ -23,6 +23,7 @@ import { loadConfig } from '@backstage/config-loader';
 export async function loadBackendConfig() {
   const paths = findPaths(__dirname);
   const configs = await loadConfig({
+    env: process.env.NODE_ENV,
     rootPaths: [paths.targetDir, paths.targetRoot],
     shouldReadSecrets: true,
   });

packages/cli/src/commands/app/build.ts

@@ -22,6 +22,7 @@ import { buildBundle } from '../../lib/bundler';
 
 export default async (cmd: Command) => {
   const appConfigs = await loadConfig({
+    env: 'production',
     rootPaths: [paths.targetDir, paths.targetRoot],
   });
   await buildBundle({

packages/cli/src/commands/app/serve.ts

@@ -22,6 +22,7 @@ import { serveBundle } from '../../lib/bundler';
 
 export default async (cmd: Command) => {
   const appConfigs = await loadConfig({
+    env: 'development',
     rootPaths: [paths.targetDir, paths.targetRoot],
   });
   const waitForExit = await serveBundle({

packages/cli/src/commands/backend/dev.ts

@@ -22,6 +22,7 @@ import { serveBackend } from '../../lib/bundler/backend';
 
 export default async (cmd: Command) => {
   const appConfigs = await loadConfig({
+    env: 'development',
     rootPaths: [paths.targetDir, paths.targetRoot],
   });
   const waitForExit = await serveBackend({

packages/cli/src/commands/plugin/export.ts

@@ -22,6 +22,7 @@ import { buildBundle } from '../../lib/bundler';
 
 export default async (cmd: Command) => {
   const appConfigs = await loadConfig({
+    env: 'production',
     rootPaths: [paths.targetDir, paths.targetRoot],
   });
   await buildBundle({

packages/cli/src/commands/plugin/serve.ts

@@ -22,6 +22,7 @@ import { serveBundle } from '../../lib/bundler';
 
 export default async (cmd: Command) => {
   const appConfigs = await loadConfig({
+    env: 'development',
     rootPaths: [paths.targetDir, paths.targetRoot],
   });
   const waitForExit = await serveBundle({

packages/config-loader/src/lib/resolver.ts

@@ -20,6 +20,8 @@ import { pathExists } from 'fs-extra';
 type ResolveOptions = {
   // Root paths to search for config files. Config from earlier paths has higher priority.
   rootPaths: string[];
+  // The environment that we're loading config for, e.g. 'development', 'production'.
+  env: string;
 };
 
 /**
@@ -35,11 +37,9 @@ type ResolveOptions = {
 export async function resolveStaticConfig(
   options: ResolveOptions,
 ): Promise<string[]> {
-  const env = process.env.NODE_ENV ?? 'development';
-
   const filePaths = [
-    `app-config.${env}.local.yaml`,
-    `app-config.${env}.yaml`,
+    `app-config.${options.env}.local.yaml`,
+    `app-config.${options.env}.yaml`,
     `app-config.local.yaml`,
     `app-config.yaml`,
   ];

packages/config-loader/src/loader.ts

@@ -28,6 +28,9 @@ export type LoadConfigOptions = {
   // Root paths to search for config files. Config from earlier paths has higher priority.
   rootPaths: string[];
 
+  // The environment that we're loading config for, e.g. 'development', 'production'.
+  env: string;
+
   // Whether to read secrets or omit them, defaults to false.
   shouldReadSecrets?: boolean;
 };