Fix some remaining typing issues

Signed-off-by: Oliver Sand <oliver.sand@sda-se.com>
This commit is contained in:
Oliver Sand
2021-04-22 13:08:20 +02:00
parent bf905d9bde
commit a3048a3b7f
4 changed files with 24 additions and 10 deletions
@@ -51,8 +51,19 @@ describe('<TechDocsPage />', () => {
});
const techdocsApi: Partial<TechDocsApi> = {
getEntityMetadata: () => Promise.resolve([]),
getTechDocsMetadata: () => Promise.resolve([]),
getEntityMetadata: () =>
Promise.resolve({
apiVersion: 'v1',
kind: 'Component',
metadata: {
name: 'backstage',
},
}),
getTechDocsMetadata: () =>
Promise.resolve({
site_name: 'string',
site_description: 'string',
}),
};
const techdocsStorageApi: Partial<TechDocsStorageApi> = {
getEntityDocs: (): Promise<string> => Promise.resolve('String'),
@@ -14,13 +14,13 @@
* limitations under the License.
*/
import { Content, Page, useApi } from '@backstage/core';
import React, { useState } from 'react';
import { useParams } from 'react-router-dom';
import { Content, Page, useApi } from '@backstage/core';
import { Reader } from './Reader';
import { useAsync } from 'react-use';
import { TechDocsPageHeader } from './TechDocsPageHeader';
import { techdocsApiRef } from '../../api';
import { Reader } from './Reader';
import { TechDocsPageHeader } from './TechDocsPageHeader';
export const TechDocsPage = () => {
const [documentReady, setDocumentReady] = useState<boolean>(false);
@@ -33,7 +33,7 @@ export const TechDocsPage = () => {
return techdocsApi.getTechDocsMetadata({ kind, namespace, name });
}
return Promise.resolve({ loading: true });
return Promise.resolve(undefined);
}, [kind, namespace, name, techdocsApi, documentReady]);
const entityMetadataRequest = useAsync(() => {
@@ -16,14 +16,17 @@
import { createTestShadowDom } from '../../test-utils';
import { addBaseUrl } from '../transformers';
import { TechDocsStorage } from '../../api';
import { TechDocsStorageApi } from '../../api';
const DOC_STORAGE_URL = 'https://example-host.storage.googleapis.com';
const techdocsStorageApi: TechDocsStorage = {
const techdocsStorageApi: TechDocsStorageApi = {
getBaseUrl: jest.fn(() => Promise.resolve(DOC_STORAGE_URL)),
getEntityDocs: () => new Promise(resolve => resolve('yes!')),
syncEntityDocs: () => new Promise(resolve => resolve(true)),
getApiOrigin: jest.fn(),
getBuilder: jest.fn(),
getStorageUrl: jest.fn(),
};
const fixture = `
@@ -15,10 +15,10 @@
*/
import { EntityName } from '@backstage/catalog-model';
import type { Transformer } from './index';
import { TechDocsStorage } from '../../api';
import { TechDocsStorageApi } from '../../api';
type AddBaseUrlOptions = {
techdocsStorageApi: TechDocsStorage;
techdocsStorageApi: TechDocsStorageApi;
entityId: EntityName;
path: string;
};