Address comments

Signed-off-by: Douglas Read <read.d@northeastern.edu>
This commit is contained in:
Douglas Read
2021-09-15 22:13:15 -04:00
parent fe5409c6f2
commit a0b64bf46e
2 changed files with 6 additions and 7 deletions
@@ -28,6 +28,7 @@ import { DateTime, Duration } from 'luxon';
import { ChangeEvent } from '../types';
import OpenInBrowserIcon from '@material-ui/icons/OpenInBrowser';
import { BackstageTheme } from '@backstage/theme';
import { Link } from '@backstage/core-components';
const useStyles = makeStyles<BackstageTheme>({
denseListIcon: {
@@ -59,9 +60,8 @@ export const ChangeEventListItem = ({ changeEvent }: Props) => {
externalLinkElem = (
<Tooltip title={text} placement="top">
<IconButton
href={changeEvent.links[0].href}
target="_blank"
rel="noopener noreferrer"
component={Link}
to={changeEvent.links[0].href}
color="primary"
>
<OpenInBrowserIcon />
@@ -88,9 +88,8 @@ export const ChangeEventListItem = ({ changeEvent }: Props) => {
{externalLinkElem}
<Tooltip title="View in Pagerduty" placement="top">
<IconButton
href={changeEvent.html_url}
target="_blank"
rel="noopener noreferrer"
component={Link}
to={changeEvent.html_url}
color="primary"
>
<OpenInBrowserIcon />
+1 -1
View File
@@ -1,5 +1,5 @@
/*
* Copyright 2020 Spotify AB
* Copyright 2020 The Backstage Authors
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.