Reset error on success path

If a re-render - or simply the intervalMs parameter - causes a retry that
turns a previously failed operation into a successful one, the error was
previously not reset, resulting in the somewhat odd combination of an
error message and a full, successful, response data object.

This change ensures that the error state is reset every time an operation
succeeds, so the UI state remains consistent.

Signed-off-by: Tomas Aschan <tomasl@spotify.com>
This commit is contained in:
Tomas Aschan
2022-09-05 22:20:42 +02:00
parent 3420f44149
commit 9f8dd192c9
@@ -47,6 +47,7 @@ export const useKubernetesObjects = (
try {
clusters = await kubernetesApi.getClusters();
setError(null);
} catch (e) {
setError(e.message);
return;
@@ -75,6 +76,7 @@ export const useKubernetesObjects = (
authProviderStr,
requestBody,
);
setError(null);
} catch (e) {
setError(e.message);
return;
@@ -83,6 +85,7 @@ export const useKubernetesObjects = (
try {
setKubernetesObjects(await kubernetesApi.getObjectsByEntity(requestBody));
setError(null);
} catch (e) {
setError(e.message);
return;