From 9f8dd192c99f06e64986e506d42f3f36b41650a6 Mon Sep 17 00:00:00 2001
From: Tomas Aschan <tomasl@spotify.com>
Date: Mon, 5 Sep 2022 22:20:42 +0200
Subject: [PATCH] Reset error on success path

If a re-render - or simply the intervalMs parameter - causes a retry that
turns a previously failed operation into a successful one, the error was
previously not reset, resulting in the somewhat odd combination of an
error message and a full, successful, response data object.

This change ensures that the error state is reset every time an operation
succeeds, so the UI state remains consistent.

Signed-off-by: Tomas Aschan <tomasl@spotify.com>
---
 plugins/kubernetes/src/hooks/useKubernetesObjects.ts | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/plugins/kubernetes/src/hooks/useKubernetesObjects.ts b/plugins/kubernetes/src/hooks/useKubernetesObjects.ts
index 8e2597c1d2..70281d8d49 100644
--- a/plugins/kubernetes/src/hooks/useKubernetesObjects.ts
+++ b/plugins/kubernetes/src/hooks/useKubernetesObjects.ts
@@ -47,6 +47,7 @@ export const useKubernetesObjects = (
 
     try {
       clusters = await kubernetesApi.getClusters();
+      setError(null);
     } catch (e) {
       setError(e.message);
       return;
@@ -75,6 +76,7 @@ export const useKubernetesObjects = (
             authProviderStr,
             requestBody,
           );
+        setError(null);
       } catch (e) {
         setError(e.message);
         return;
@@ -83,6 +85,7 @@ export const useKubernetesObjects = (
 
     try {
       setKubernetesObjects(await kubernetesApi.getObjectsByEntity(requestBody));
+      setError(null);
     } catch (e) {
       setError(e.message);
       return;