Apply suggestions from code review
Co-authored-by: Johan Haals <johan@haals.se> Signed-off-by: Tracey Radcliffe <tradcliffe@expediagroup.com>
This commit is contained in:
@@ -2,4 +2,4 @@
|
||||
'@backstage/plugin-scaffolder-backend-module-confluence-to-markdown': minor
|
||||
---
|
||||
|
||||
Created new action for converting confluence docs to Markdown, to be pushed to GitHub repos configured for Techdocs
|
||||
Created `confluence:transform:markdown` action for converting confluence docs to Markdown.
|
||||
|
||||
@@ -111,12 +111,6 @@ spec:
|
||||
branchName: confluence-to-markdown
|
||||
title: Confluence to Markdown
|
||||
description: PR for converting confluence page to mkdocs
|
||||
- id: merge
|
||||
name: Merge PR
|
||||
action: publish:github:merge-pull-request
|
||||
input:
|
||||
prUrl: ${{ steps['publish'].output.remoteUrl }}
|
||||
forceAdmin: true
|
||||
```
|
||||
|
||||
Replace `<GITHUB_BASE_URL>` with your GitHub URL without `https://`.
|
||||
|
||||
+1
-1
@@ -61,7 +61,7 @@ export const fetchConfluence = async (relativeUrl: string, config: Config) => {
|
||||
throw await ResponseError.fromResponse(response);
|
||||
}
|
||||
|
||||
return response.json() as Promise<any>;
|
||||
return response.json();
|
||||
};
|
||||
|
||||
export const getAndWriteAttachments = async (
|
||||
|
||||
Reference in New Issue
Block a user