Merge pull request #17657 from grupoboticario/fix/github-org-description-team-edited
Fix/ GitHubOrgEntityProvider description was not changing
This commit is contained in:
@@ -0,0 +1,5 @@
|
||||
---
|
||||
'@backstage/plugin-catalog-backend-module-github': major
|
||||
---
|
||||
|
||||
Updated the `team.edited` event emitted from `GithubOrgEntityProvider` to also include teams description.
|
||||
@@ -833,6 +833,7 @@ describe('GithubOrgEntityProvider', () => {
|
||||
'url:https://github.com/orgs/backstage/teams/mygroup-with-spaces',
|
||||
},
|
||||
name: 'mygroup-with-spaces',
|
||||
description: 'description-from-the-new-team',
|
||||
},
|
||||
apiVersion: 'backstage.io/v1alpha1',
|
||||
kind: 'Group',
|
||||
|
||||
@@ -371,14 +371,21 @@ export class GithubOrgEntityProvider
|
||||
assignGroupsToUsers(usersToRebuild, groups);
|
||||
buildOrgHierarchy(groups);
|
||||
|
||||
const oldName = event.changes.name?.from || '';
|
||||
const oldName = event.changes.name?.from || event.team.name;
|
||||
const oldSlug = oldName.toLowerCase().replaceAll(/\s/gi, '-');
|
||||
|
||||
const oldDescription =
|
||||
event.changes.description?.from || event.team.description;
|
||||
const oldDescriptionSlug = oldDescription
|
||||
?.toLowerCase()
|
||||
.replaceAll(/\s/gi, '-');
|
||||
|
||||
const { removed } = createDeltaOperation(org, [
|
||||
{
|
||||
...group,
|
||||
metadata: {
|
||||
name: oldSlug,
|
||||
description: oldDescriptionSlug,
|
||||
},
|
||||
},
|
||||
]);
|
||||
|
||||
Reference in New Issue
Block a user