Merge pull request #17548 from awanlin/topic/fix-search-404-due-to-encoding

Fixed search 404 caused by URL encoding change
This commit is contained in:
Fredrik Adelöw
2023-04-29 12:23:10 +02:00
committed by GitHub
3 changed files with 11 additions and 6 deletions
+5
View File
@@ -0,0 +1,5 @@
---
'@backstage/plugin-search': patch
---
Fixed 404 Error when fetching search results due to URL encoding changes
+4 -4
View File
@@ -51,8 +51,8 @@ describe('apis', () => {
it('Fetch is called with expected URL (including stringified Q params)', async () => {
await client.query(query);
expect(getBaseUrl).toHaveBeenLastCalledWith('search/query');
expect(fetch).toHaveBeenLastCalledWith(`${baseUrl}?term=`, {
expect(getBaseUrl).toHaveBeenLastCalledWith('search');
expect(fetch).toHaveBeenLastCalledWith(`${baseUrl}/query?term=`, {
headers: {},
});
});
@@ -63,8 +63,8 @@ describe('apis', () => {
identityApi: createIdentityApiMock(withToken),
});
await authedClient.query(query);
expect(getBaseUrl).toHaveBeenLastCalledWith('search/query');
expect(fetch).toHaveBeenLastCalledWith(`${baseUrl}?term=`, {
expect(getBaseUrl).toHaveBeenLastCalledWith('search');
expect(fetch).toHaveBeenLastCalledWith(`${baseUrl}/query?term=`, {
headers: { Authorization: `Bearer ${token}` },
});
});
+2 -2
View File
@@ -37,8 +37,8 @@ export class SearchClient implements SearchApi {
const { token } = await this.identityApi.getCredentials();
const queryString = qs.stringify(query);
const url = `${await this.discoveryApi.getBaseUrl(
'search/query',
)}?${queryString}`;
'search',
)}/query?${queryString}`;
const response = await fetch(url, {
headers: token ? { Authorization: `Bearer ${token}` } : {},
});