paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 30 Packages Projects Releases Wiki Activity

chore(gql/catalog): fixing some code review comments

Browse Source
This commit is contained in:
blam
2020-08-14 14:37:17 +02:00
parent a09e949b6f
commit 9b3236f47e
4 changed files with 13 additions and 82 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/catalog-graphql/package.json
+1 -2
View File
@@ -44,7 +44,6 @@
"supertest": "^4.0.2"
},
"files": [
"dist",
"schema.gql"
"dist"
]
}
plugins/graphql/package.json
+2 -2
View File
@@ -24,8 +24,8 @@
"@backstage/plugin-catalog-graphql": "^0.1.1-alpha.18",
"@graphql-modules/core": "^0.7.17",
"@types/express": "^4.17.6",
"apollo-server": "^2.16.0",
"apollo-server-express": "^2.16.0",
"apollo-server": "^2.16.1",
"apollo-server-express": "^2.16.1",
"express": "^4.17.1",
"express-promise-router": "^3.0.3",
"graphql": "^15.3.0",
plugins/graphql/src/service/router.ts
+10 -7
View File
@@ -51,19 +51,22 @@ export async function createRouter(
const server = new ApolloServer({
schema,
logger: options.logger,
introspection: true,
playground: process.env.NODE_ENV === 'development',
});
const router = Router();
const apolloMiddlware = server.getMiddleware({ path: '/' });
router.use(
helmet.contentSecurityPolicy({
directives: {
defaultSrc: ["'self'", "'unsafe-inline'", 'http://*'],
},
}),
);
if (process.env.NODE_ENV === 'development')
router.use(
helmet.contentSecurityPolicy({
directives: {
defaultSrc: ["'self'", "'unsafe-inline'", 'http://*'],
},
}),
);
router.use(apolloMiddlware);
yarn.lock
-71
View File
@@ -4703,16 +4703,6 @@
"@types/qs" "*"
"@types/serve-static" "*"
"@types/express@4.17.4":
version "4.17.4"
resolved "https://registry.npmjs.org/@types/express/-/express-4.17.4.tgz#e78bf09f3f530889575f4da8a94cd45384520aac"
integrity sha512-DO1L53rGqIDUEvOjJKmbMEQ5Z+BM2cIEPy/eV3En+s166Gz+FeuzRerxcab757u/U4v4XF4RYrZPmqKa+aY/2w==
dependencies:
"@types/body-parser" "*"
"@types/express-serve-static-core" "*"
"@types/qs" "*"
"@types/serve-static" "*"
"@types/fs-capacitor@*":
version "2.0.0"
resolved "https://registry.npmjs.org/@types/fs-capacitor/-/fs-capacitor-2.0.0.tgz#17113e25817f584f58100fb7a08eed288b81956e"
@@ -6091,34 +6081,6 @@ apollo-server-caching@^0.5.2:
dependencies:
lru-cache "^5.0.0"
apollo-server-core@^2.16.0:
version "2.16.0"
resolved "https://registry.npmjs.org/apollo-server-core/-/apollo-server-core-2.16.0.tgz#56b367db49f97b7da03b29cef89b63d9ed14ee0c"
integrity sha512-mnvg2cPvsQtjFXIqIhEAbPqGyiSXDSbiBgNQ8rY8g7r2eRMhHKZePqGF03gP1/w87yVaSDRAZBDk6o+jiBXjVQ==
dependencies:
"@apollographql/apollo-tools" "^0.4.3"
"@apollographql/graphql-playground-html" "1.6.26"
"@types/graphql-upload" "^8.0.0"
"@types/ws" "^7.0.0"
apollo-cache-control "^0.11.1"
apollo-datasource "^0.7.2"
apollo-engine-reporting "^2.3.0"
apollo-server-caching "^0.5.2"
apollo-server-env "^2.4.5"
apollo-server-errors "^2.4.2"
apollo-server-plugin-base "^0.9.1"
apollo-server-types "^0.5.1"
apollo-tracing "^0.11.1"
fast-json-stable-stringify "^2.0.0"
graphql-extensions "^0.12.4"
graphql-tag "^2.9.2"
graphql-tools "^4.0.0"
graphql-upload "^8.0.2"
loglevel "^1.6.7"
sha.js "^2.4.11"
subscriptions-transport-ws "^0.9.11"
ws "^6.0.0"
apollo-server-core@^2.16.1:
version "2.16.1"
resolved "https://registry.npmjs.org/apollo-server-core/-/apollo-server-core-2.16.1.tgz#5b5b8245ab9c0cb6c2367ec19ab855dea6ccea3a"
@@ -6160,28 +6122,6 @@ apollo-server-errors@^2.4.2:
resolved "https://registry.npmjs.org/apollo-server-errors/-/apollo-server-errors-2.4.2.tgz#1128738a1d14da989f58420896d70524784eabe5"
integrity sha512-FeGxW3Batn6sUtX3OVVUm7o56EgjxDlmgpTLNyWcLb0j6P8mw9oLNyAm3B+deHA4KNdNHO5BmHS2g1SJYjqPCQ==
apollo-server-express@^2.16.0:
version "2.16.0"
resolved "https://registry.npmjs.org/apollo-server-express/-/apollo-server-express-2.16.0.tgz#3474a7f7eb868a2a847a364839147f8d7f26454a"
integrity sha512-mBIvKcF8gApj7wbmqe0A4Tsy+Pw66mI6cmtD912bG59KhUBveSCZ21dDlRSvnXUyK+GOo2ItwcUEtmks+Z2Pqw==
dependencies:
"@apollographql/graphql-playground-html" "1.6.26"
"@types/accepts" "^1.3.5"
"@types/body-parser" "1.19.0"
"@types/cors" "^2.8.4"
"@types/express" "4.17.4"
accepts "^1.3.5"
apollo-server-core "^2.16.0"
apollo-server-types "^0.5.1"
body-parser "^1.18.3"
cors "^2.8.4"
express "^4.17.1"
graphql-subscriptions "^1.0.0"
graphql-tools "^4.0.0"
parseurl "^1.3.2"
subscriptions-transport-ws "^0.9.16"
type-is "^1.6.16"
apollo-server-express@^2.16.1:
version "2.16.1"
resolved "https://registry.npmjs.org/apollo-server-express/-/apollo-server-express-2.16.1.tgz#7438bca590ef8577d24d20ba0b6d582c120c0146"
@@ -6220,17 +6160,6 @@ apollo-server-types@^0.5.1:
apollo-server-caching "^0.5.2"
apollo-server-env "^2.4.5"
apollo-server@^2.16.0:
version "2.16.0"
resolved "https://registry.npmjs.org/apollo-server/-/apollo-server-2.16.0.tgz#fa30e29b78e8cb70b2c81d0f7b96953beb3d4baf"
integrity sha512-zbEe0FSqatqE6bmIfq/o1/Hsqc596ZOwZM/L8Ttwa4ucQ1ybqf1ZejSYu6ehFEj1G6rOBY1ttVKkIllcErK4GQ==
dependencies:
apollo-server-core "^2.16.0"
apollo-server-express "^2.16.0"
express "^4.0.0"
graphql-subscriptions "^1.0.0"
graphql-tools "^4.0.0"
apollo-server@^2.16.1:
version "2.16.1"
resolved "https://registry.npmjs.org/apollo-server/-/apollo-server-2.16.1.tgz#edc319606eb29f73132239bdc005dd88ac40a142"